1396888 - Move bookmarks only moves the first bookmark with Async Places Transactions turned on

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Mark Banner (:standard8)]

STR

1) Create some bookmarks
2) Open the Library window (cmd-shift-B)
3) Create a new folder
4) Select the bookmarks and then from the cog symbol, select "Move..."
5) Choose the new folder and select OK.

Actual Results

=> Only one item is moved

Expected Results

=> All selected items are moved.

Comment 1

[Mark Banner (:standard8)]

It also looks like after selecting OK, then bookmarking functions in the Library window are disabled.

I suspect this is caused by the dialog being closed and going out of scope whilst the async transactions are happening.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening.

Review commit: https://reviewboard.mozilla.org/r/176508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176508/

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8904719 [details]
Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening.

https://reviewboard.mozilla.org/r/176508/#review181738

::: browser/components/places/content/controller.js:800
(Diff revision 1)
> +    }
> +
> +    PlacesTransactions.batch(async () => {
> +      for (let node of this._view.selectedNodes) {
> +        // Nothing to do if the node is already under the selected folder.
> +        if (node.parent.itemId == args.moveToGuid)

comparing itemId with a guid?
Also, do we risk to have an empty batch due to this continue?

::: browser/components/places/content/controller.js:805
(Diff revision 1)
> +        if (node.parent.itemId == args.moveToGuid)
> +          continue;
> +        await PlacesTransactions.Move({ guid: node.bookmarkGuid,
> +                                        newParentGuid: args.moveToGuid }).transact();
> +      }
> +    }).catch(Components.utils.reportError);

let's make moveSelectedBookmarks async, and move the catch to the caller

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8904719 [details]
Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176508/diff/1-2/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8904719 [details]
Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening.

https://reviewboard.mozilla.org/r/176508/#review181828

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80764c510b9b
Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80764c510b9b