don't warn about infinite recursion in mozalloc_abort

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 months ago
mozalloc_abort is not marked as a noreturn function on Android, so clang
complains when abort calls mozalloc_abort, which calls MOZ_CRASH, which
calls abort().  We know this is OK, so just disable the warning.
(Assignee)

Comment 1

11 months ago
Created attachment 8904612 [details] [diff] [review]
don't warn about infinite recursion in mozalloc_abort
Attachment #8904612 - Flags: review?(mh+mozilla)
(Assignee)

Updated

11 months ago
Blocks: 1163171

Comment 2

11 months ago
Comment on attachment 8904612 [details] [diff] [review]
don't warn about infinite recursion in mozalloc_abort

Review of attachment 8904612 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/mozalloc/moz.build
@@ +26,5 @@
>      SOURCES += [
>          'winheap.cpp',
>      ]
>  
> +if CONFIG['OS_TARGET'] == 'Android' and CONFIG['CC_TYPE'] == 'clang':

The ifndef in mozalloc_abort.h is for arm, not android.

@@ +28,5 @@
>      ]
>  
> +if CONFIG['OS_TARGET'] == 'Android' and CONFIG['CC_TYPE'] == 'clang':
> +    CXXFLAGS += [
> +        '-Wno-infinite-recursion',

Maybe only set this on mozalloc_abort.cpp?
Attachment #8904612 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

11 months ago
Created attachment 8907790 [details] [diff] [review]
don't warn about infinite recursion in mozalloc_abort

This should address your concerns.
Attachment #8907790 - Flags: review?(mh+mozilla)
(Assignee)

Updated

11 months ago
Attachment #8904612 - Attachment is obsolete: true

Updated

11 months ago
Attachment #8907790 - Flags: review?(mh+mozilla) → review+

Comment 4

11 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/531247b23a52
don't warn about infinite recursion in mozalloc_abort; r=glandium
https://hg.mozilla.org/mozilla-central/rev/531247b23a52
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.