about:telemetry - Pings with Environment sections but no addons subsesction trigger the Raw JSON view due to TypeError

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chutten, Assigned: chutten)

Tracking

(Blocks 1 bug)

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
If a ping has environment data, EnvironmentData.render(ping) will render it. It will then use special rendering to render the Addon data.

If the Environment block doesn't have an Addon section (due to, among other things, delayed addon init) then it defaults to showing the Raw JSON of the ping.

With the new about:telemetry redesign, showing the Raw JSON involves opening a new tab to show it using Firefox's spiffy JSON viewer.

This is jarring and avoidable.

So, instead, _check_ that an addons subsection exists before rendering one.
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8904675 - Flags: review?(gfritzsche) → review?(alessio.placitelli)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8904675 [details]
bug 1396894 - Don't error out when rendering normally-structured pings

https://reviewboard.mozilla.org/r/176478/#review181840

Took me a bit to figure the "key" change :S Looks good!
Attachment #8904675 - Flags: review?(alessio.placitelli) → review+

Comment 3

2 years ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378fb9246039
Don't error out when rendering normally-structured pings r=Dexter
https://hg.mozilla.org/mozilla-central/rev/378fb9246039
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.