1396912 - Stub installer progress bar stops moving at a certain point for some time

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:

Screen capture: https://testing-1.tinytake.com/sf/MTkyOTk3OF82MTQxODMx

1. Run the stub installer
2. Observe the progress bar 

Actual Result:

The progress bar stops moving at a certain point for few seconds before it exists.

Expected result:
The progress bar should keep filling up until it reaches 100%.

Comment 1

[Molly Howell (she/her) [:mhowell]]

I have a hunch about what's going on, but I haven't been able to reproduce this in order to verify it. Abe, do you think you could get a screen capture of the entire installation, starting from when the installer window first appears? That would be super helpful. Thanks.

Comment 2

[Abe - QA (:Abe_LV)]

Here is the screen capture: https://testing-1.tinytake.com/sf/MTkzMDYwNF82MTQzMTg0

I am on windows 10 64 bits OS.
--
Version 	57.0a1
Build ID 	20170905100117
Update Channel 	nightly
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 3

[Molly Howell (she/her) [:mhowell]]

Thanks, that's perfect. What's happening is that the bar is filling up too quickly during the install phase, so it gets to where it would be at the end of that phase well before the install operation is actually done. This is because I forgot to scale the bar position by the install timeout. Patch coming up.

Comment 4

[Molly Howell (she/her) [:mhowell]]

Attachment: Bug 1396912 - Advance the stub installer progress bar at the correct rate during the install phase.

Review commit: https://reviewboard.mozilla.org/r/176542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176542/

Comment 5

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8904759 [details]
Bug 1396912 - Advance the stub installer progress bar at the correct rate during the install phase.

https://reviewboard.mozilla.org/r/176542/#review181582

Looks good, sorry I missed this last time. I didn't think we'd want the install phase to progress so slowly, but also didn't realize how bad the pause would look.

Comment 6

[Molly Howell (she/her) [:mhowell]]

Comment on attachment 8904759 [details]
Bug 1396912 - Advance the stub installer progress bar at the correct rate during the install phase.

https://reviewboard.mozilla.org/r/176542/#review181582

I agree it's not ideal, but it will at least match the previous behavior this way.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdb66df9fbc2
Advance the stub installer progress bar at the correct rate during the install phase. r=agashlin

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fdb66df9fbc2

Comment 9

[Abe - QA (:Abe_LV)]

verified as fixed.