Closed
Bug 1396932
Opened 7 years ago
Closed 7 years ago
Watchpoint map doesn't need to rekey entries
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
4.08 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Since the watchpoint map now bases its hash code on unique IDs, we don't need to rekey if cells are moved and can update the key in place. The simplifies some gnarly code.
Attachment #8904656 -
Flags: review?(sphink)
Updated•7 years ago
|
Attachment #8904656 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1a2ad4d811 Remove unncessary rekeying of watchpoint map r=sfink
Comment 2•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d1a2ad4d811
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•