Simplify tenuring of objects with unique IDs

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

55 Branch
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Here's a patch to simplify the handling of objects with unique IDs.  We have a list of these so we don't need to do a hash table lookup for every object we tenure.  I refactored the nursery sweeping code into separate sweep and clear parts too.
Attachment #8904661 - Flags: review?(sphink)
Comment on attachment 8904661 [details] [diff] [review]
improve-unique-id-sweep

Review of attachment 8904661 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, wow. This seems like a pretty big deal.

::: js/src/gc/Nursery.h
@@ +474,5 @@
>      void freeMallocedBuffers();
>  
>      /*
> +     * Updates pointers to nursery objects that have been tenured and discards
> +     * to pointers to objects that have been freed.

s/to pointers/pointers/
Attachment #8904661 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c55a6e0ff0f
Simplify tenuring of objects with unique IDs and remove hash table lookup for every tenured object r=sfink
https://hg.mozilla.org/mozilla-central/rev/6c55a6e0ff0f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.