Closed
Bug 1396936
Opened 7 years ago
Closed 7 years ago
Simplify tenuring of objects with unique IDs
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
7.83 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Here's a patch to simplify the handling of objects with unique IDs. We have a list of these so we don't need to do a hash table lookup for every object we tenure. I refactored the nursery sweeping code into separate sweep and clear parts too.
Attachment #8904661 -
Flags: review?(sphink)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8904661 [details] [diff] [review] improve-unique-id-sweep Review of attachment 8904661 [details] [diff] [review]: ----------------------------------------------------------------- Oh, wow. This seems like a pretty big deal. ::: js/src/gc/Nursery.h @@ +474,5 @@ > void freeMallocedBuffers(); > > /* > + * Updates pointers to nursery objects that have been tenured and discards > + * to pointers to objects that have been freed. s/to pointers/pointers/
Attachment #8904661 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c55a6e0ff0f Simplify tenuring of objects with unique IDs and remove hash table lookup for every tenured object r=sfink
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6c55a6e0ff0f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•