Closed
Bug 1396967
Opened 7 years ago
Closed 7 years ago
Fix undeclared assignments in mozmill
Categories
(Testing Graveyard :: TPS, enhancement)
Testing Graveyard
TPS
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
Now that we evaluate modules in strict mode by default, undeclared assignments are fatal errors. I think this might be causing warnings in TPS like "JavaScript error: resource://mozmill/driver/controller.js, line 31: ReferenceError: assignment to undeclared variable waitForEvents", but it's not clear to me if they're also causing the failures.
Assignee | ||
Comment 1•7 years ago
|
||
Hmm, I'm getting errors like this trying to run TPS locally, so I'm not sure if this patch fixes the issue: TEST-UNEXPECTED-FAIL | test_existing_bookmarks.js | [phase phase1] RunNextTestAction failed - Error: signIn() failed with: The request was blocked for security reasons (resource://tps/auth/fxaccounts.jsm:185:13) JS Stack trace: signIn@fxaccounts.jsm:185:13 < async*Login@tps.jsm:1154:11 < async*RunNextTestAction@tps.jsm:779:13 < async*_executeTestPhase@tps.jsm:961:13 < async*RunTestPhase@tps.jsm:899:13 < async*onStartupFinished@file:///var/folders/qv/q7lf58552szfnlqd8220txgw0000gn/T/tmp77hMqy.mozrunner/extensions/tps@tps-cmdline.js:72:7 < _delayedStartup@browser.js:1692:5 < EventListener.handleEvent*onLoad@browser.js:1387:5 < onload@browser.xul:1:1
Blocks: 1394556
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Whoops, I didn't see that Mark already fixed `waitForEvents` in bug 1396740. This patch fixes up some others.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8904691 [details] Bug 1396967 - Fix undeclared assignments in MozMill. https://reviewboard.mozilla.org/r/176488/#review181466 These all look good (and it's surprising some of this even works -- I'd guess it actually doesn't) but it conflicts with 1396740, so wait for that to land and rebase on top. We should consider removing the mozmill portions of TPS, since it's unclear to me what their purpose is anymore.
Attachment #8904691 -
Flags: review?(tchiovoloni) → review+
Comment hidden (mozreview-request) |
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0e1550d7bde Fix undeclared assignments in MozMill. r=tcsc
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d0e1550d7bde
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•