Closed Bug 1396967 Opened 2 years ago Closed 2 years ago
Fix undeclared assignments in mozmill
59 bytes, text/x-review-board-request
Hmm, I'm getting errors like this trying to run TPS locally, so I'm not sure if this patch fixes the issue: TEST-UNEXPECTED-FAIL | test_existing_bookmarks.js | [phase phase1] RunNextTestAction failed - Error: signIn() failed with: The request was blocked for security reasons (resource://tps/auth/fxaccounts.jsm:185:13) JS Stack trace: signIn@fxaccounts.jsm:185:13 < async*Login@tps.jsm:1154:11 < async*RunNextTestAction@tps.jsm:779:13 < async*_executeTestPhase@tps.jsm:961:13 < async*RunTestPhase@tps.jsm:899:13 < async*onStartupFinished@file:///var/folders/qv/q7lf58552szfnlqd8220txgw0000gn/T/tmp77hMqy.email@example.com:72:7 < _delayedStartup@browser.js:1692:5 < EventListener.handleEvent*onLoad@browser.js:1387:5 < firstname.lastname@example.org:1:1
Whoops, I didn't see that Mark already fixed `waitForEvents` in bug 1396740. This patch fixes up some others.
Component: Sync → TPS
Depends on: 1396740
Product: Firefox → Testing
Comment on attachment 8904691 [details] Bug 1396967 - Fix undeclared assignments in MozMill. https://reviewboard.mozilla.org/r/176488/#review181466 These all look good (and it's surprising some of this even works -- I'd guess it actually doesn't) but it conflicts with 1396740, so wait for that to land and rebase on top. We should consider removing the mozmill portions of TPS, since it's unclear to me what their purpose is anymore.
Attachment #8904691 - Flags: review?(tchiovoloni) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d0e1550d7bde Fix undeclared assignments in MozMill. r=tcsc
You need to log in before you can comment on or make changes to this bug.