Update distributions suggestedsites specs to match new AS format




Firefox for Android
6 months ago
5 months ago


(Reporter: mcomella, Assigned: mkaply)


(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)


(Whiteboard: [mobileAS])

Comment hidden (empty)
We changed the top sites suggestedsites format in bug 1388379 - this bug is to update the specs so distributions can change their configurations for the new format. We're blocked on bug 1391413 to know if the appearance of titles will change with distributions since ~10 characters is hard to present an identifiable title in while maintaining brand identity.

Break-out from bug 1394641; adding to the current sprint.
Blocks: 1396946
Iteration: --- → 1.29
Depends on: 1388379, 1391413
Priority: -- → P1
Summary: Update distributions suggestedsites specs to match new format → Update distributions suggestedsites specs to match new AS format
Whiteboard: [mobileAS]
We're also blocked on bug 1394641 to know if the bgcolor property will stay around or not.
Depends on: 1394641
Note: this doesn't need to be done before 57 lands but it's ideal to just in case there are problems.
No longer depends on: 1394641
We should update the specs with the following information:

Icons should be given in the following formats:
- hdpi: 135x135
- xhdpi: 180x180
- xxhdpi: 270x270

Titles are one line (maybe 2 after bug 1391413) so they need to be short.


Reasoning for ^:
- We updated the icon sizes in bug 1388379.
- The titles in the new AS are pretty short.
- I decided not to remove the bgcolor attribute in bug 1394641 comment 20 to avoid churn and confusion, even if the property is often unused (though in some distributions, this is already the case)


To update the specs:

(In reply to Mike Kaply [:mkaply] from bug 1394641 comment #9)
> > 2) How would I update the distribution specs? Do I just update https://wiki.mozilla.org/Mobile/Distribution_Files#Suggested_sites directly? If so, how do I ensure distributions created up to FF 56 don't accidentally use the new format (if that's even a problem)?
> Yes. I'm responsible for the actual code around these distributions, so I
> can make necessary updated.
NI self to follow-up with mkaply once bug 1394641 lands - I think he should update the docs to make sure it all goes in the right place and so he can get started on bug 1396994.
Depends on: 1394641
Flags: needinfo?(michael.l.comella)
Mike would you be able to update the specs (this bug) and follow-up by notifying our distributions of the new requirements (bug 1396994)? They are:

(In reply to Michael Comella (:mcomella) from comment #4)
> Icons should be given in the following formats:
> - hdpi: 135x135
> - xhdpi: 180x180
> - xxhdpi: 270x270 

Titles are one line so they need to be short.
Flags: needinfo?(michael.l.comella) → needinfo?(mozilla)


5 months ago
Iteration: 1.29 → 1.30

Comment 7

5 months ago
I've updated https://wiki.mozilla.org/Mobile/Distribution_Files#Suggested_sites with the information.
Last Resolved: 5 months ago
Flags: needinfo?(mozilla)
Resolution: --- → FIXED
Thanks Mike!

That being said, based on code complexity we changed our decision [1] and will now allow two lines for distribution tiles all the time: I've updated the title-related text to:

> Ideally, the title of your suggested site should be short so that it only displays on one line and
> does not cover too much of the suggested site icon. That being said, there is a maximum of 2 lines
> for distribution suggested site titles. Multiple suggested sites should not begin with the same text. 

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1391413#c35
Assignee: nobody → mozilla
You need to log in before you can comment on or make changes to this bug.