Save Page As... should be disabled for preferences, new tab, and add-ons (all about: pages ?)

ASSIGNED
Assigned to

Status

()

Firefox
Menus
P1
normal
ASSIGNED
8 months ago
6 months ago

People

(Reporter: asa, Assigned: jaws)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox57 wontfix)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
The main menu lets you save these about pages but that's not a useful feature. The menu item should be disabled for about: pages or at least the main ones.
(Assignee)

Updated

6 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
status-firefox57: affected → wontfix
Comment hidden (mozreview-request)
The patch I'm attaching fixes this (not for about:newtab because we don't show that page as a secure-internal page). It shims this in through where we update the page identity UI which might not be the best place but it limits it to the only place where we make that distinction right now.
(Assignee)

Updated

6 months ago
Priority: -- → P1

Comment 3

6 months ago
mozreview-review
Comment on attachment 8924301 [details]
Bug 1396992 - Disable the save page command when on secure internal pages.

https://reviewboard.mozilla.org/r/195546/#review200776

The implementation lgtm.  Is there a context for this change though?  If Save's not useful on these pages, then Email Link, Print, Text Encoding, and Page Info aren't either I would think...  I'm not really suggesting that we disable them too, but this bug seems kind of arbitrary to me, separate from a context of how the browser UI should change on these pages.
Attachment #8924301 - Flags: review?(adw) → review+
You need to log in before you can comment on or make changes to this bug.