Closed
Bug 1397058
Opened 7 years ago
Closed 7 years ago
Add TYPE_RENDERS_NO_IMAGES flags to all applicable display items
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
11.65 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
We have this flag, but it was only applied to a few items. This patch just goes through and adds it everywhere we can, and makes the flags parameter compulsary.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8904770 -
Flags: review?(mstange)
Comment 2•7 years ago
|
||
Comment on attachment 8904770 [details] [diff] [review] flags-update Review of attachment 8904770 [details] [diff] [review]: ----------------------------------------------------------------- Having the reverse flag might make more sense, e.g. TYPE_CAN_RENDER_IMAGES
Attachment #8904770 -
Flags: review?(mstange) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/951b97610913 Make display item type flags compulsary and add them for all item types. r=mstange
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/951b97610913
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 5•7 years ago
|
||
Backed out bug 1397058 and bug 1397060 for almost permafailing reftest box-decoration-break-with-outset-box-shadow-1.html on stylo. More details in bug 1399461. bug 1397058 https://hg.mozilla.org/mozilla-central/rev/6266decf217d4da5a18115cb5b1ff70feb76e7a5 bug 1397060 https://hg.mozilla.org/mozilla-central/rev/850ec078a6adefce651d8c97c3db53fc91a02e34
Status: RESOLVED → REOPENED
status-firefox57:
fixed → ---
Flags: needinfo?(matt.woodrow)
Resolution: FIXED → ---
Target Milestone: mozilla57 → ---
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/160e7920634d Make display item type flags compulsary and add them for all item types. r=mstange
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(matt.woodrow)
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/160e7920634d
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4e8d6d2c8216 Fix reftest annotations for box-decoration-break-with-outset-box-shadow-1.html
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e8d6d2c8216
You need to log in
before you can comment on or make changes to this bug.
Description
•