Closed Bug 1397060 Opened 2 years ago Closed 2 years ago

Don't call ComputeOpaqueRect unless we're going to use the results

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

We're currently calling ComputeOpaqueRect early, even though we usually take the early return in Accumulate and don't use the result.

This just defers the call until we know if we actually need the result.
Attachment #8904769 - Flags: review?(mstange)
Attachment #8904769 - Flags: review?(mstange) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b507473b9b75
Don't call ComputeOpaqueRect unless we're going to make use of the result. r=mstange
https://hg.mozilla.org/mozilla-central/rev/b507473b9b75
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Backed out bug 1397058 and bug 1397060 for almost permafailing reftest box-decoration-break-with-outset-box-shadow-1.html on stylo. More details in bug 1399461.

bug 1397058
https://hg.mozilla.org/mozilla-central/rev/6266decf217d4da5a18115cb5b1ff70feb76e7a5

bug 1397060
https://hg.mozilla.org/mozilla-central/rev/850ec078a6adefce651d8c97c3db53fc91a02e34
Status: RESOLVED → REOPENED
Flags: needinfo?(matt.woodrow)
Resolution: FIXED → ---
Target Milestone: mozilla57 → ---
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8384b2a43a1b
Don't call ComputeOpaqueRect unless we're going to make use of the result. r=mstange
Flags: needinfo?(matt.woodrow)
https://hg.mozilla.org/mozilla-central/rev/8384b2a43a1b
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.