1397087 - Sync's _shouldLogin appears confused as to whether it is actually _canLogin

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

A followup from bug 1396544 comment 4.

_shouldLogin: http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/services/sync/modules/service.js#1036

it basically says "return true if I'm online, sync is enabled and not already logged in"

However, a key caller if this is at http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/services/sync/modules/service.js#1076

it basically says "if _shouldLogin returns false, there's no need to login - just start syncing" - but that's clearly not the right thing to do if it returns false due to being offline.

In short, _shouldLogin appears confused as to whether it is really *can* I log in versus *should* I log in.

Making the change suggested in bug 1396544 comment 4 breaks a number of tests - instead of login failures when sync isn't configured, the tests see obscure sync errors - so I'm punting on that and opening this bug instead.

It's probably best to just do bug 821143 instead though.

Comment 1

[Lina Butler [:lina]]

Backlogged; I don't think this will make the cut-off for 57.