Closed Bug 1397094 Opened 4 years ago Closed 4 years ago

Use the --theme-body-background color for the breadcrumbs

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Revert some of the changes made in Bug 1396037 to keep the breadcrumb toolbar background the same as the body background color.
Attachment #8904812 - Flags: review?(pbrosset)
Comment on attachment 8904812 [details] [diff] [review]
1397094.patch [1.0]

Review of attachment 8904812 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/themes/inspector.css
@@ +116,5 @@
>    padding: 0px;
>    border-bottom-width: 0px;
>    border-top-width: 1px;
>    border-top-color: var(--theme-splitter-color);
> +  /* Bug 1262668 - Use the same background as the body so the breadcrumbs toolbar doesn't 

nit: trailing white space.
Attachment #8904812 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5ae3bf0cb1a
Use the --theme-body-background color for the breadcrumbs. r=pbro
Duplicate of this bug: 1397337
https://hg.mozilla.org/mozilla-central/rev/c5ae3bf0cb1a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.