[Form Autofill] Tune the height of form autofill dropdown item from 29px to 30px

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Form Manager
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: ralin, Assigned: ralin)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox56 unaffected, firefox57 fixed)

Details

(Whiteboard: [form autofill:MVP])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
It's a visual enhancement derived from Fang's review. Let's have a quick fix making item a bit higher to align with the spec.
Comment hidden (mozreview-request)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8904865 [details]
Bug 1397116 - Adjust form autofill dropdown item height to 30px to align with visual spec.

https://reviewboard.mozilla.org/r/176642/#review181648
Attachment #8904865 - Flags: review?(lchang) → review+
(Assignee)

Comment 3

2 months ago
Thanks
Keywords: checkin-needed

Comment 4

2 months ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/926d1e8e0741
Adjust form autofill dropdown item height to 30px to align with visual spec. r=lchang
Keywords: checkin-needed

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/926d1e8e0741
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Updated

2 months ago
status-firefox56: --- → unaffected
You need to log in before you can comment on or make changes to this bug.