Closed Bug 1397119 Opened 2 years ago Closed Last year

Move GetBStartBCBorderWidth, GetBEndBCBorderWidth and any similar methods' return type to BCPixelSize rather than nscoord

Categories

(Core :: Layout: Tables, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
geckoview62 --- wontfix
firefox-esr60 --- wontfix
firefox57 --- wontfix
firefox58 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: ywu, Assigned: cpeterson)

References

Details

Attachments

(2 files)

Per Bug Comment 21 mentioned, 

we should change these methods on nsTableRowFrame:
  nscoord GetBStartBCBorderWidth() const { return mBStartBorderWidth; }
  nscoord GetBEndBCBorderWidth() const { return mBEndBorderWidth; }
and any similar methods (like the two on nsTableColFrame) return BCPixelSize
rather than nscoord.
s/Per Bug Comment 21/Per Bug 895096 Comment 21
Priority: -- → P3
Assignee: ywu → nobody
Bug 895096 comment 0 recommends using the name `d2a` instead of `p2t`.

Depends on D5368
Comment on attachment 9007488 [details]
Bug 1397119 - Part 1: Change nsTable*Frame::Get*BorderWidth() return values from nscoord to BCPixelSize. r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.
Attachment #9007488 - Flags: review+
Comment on attachment 9007489 [details]
Bug 1397119 - Part 2: Rename p2t to d2a (app units per device pixel). r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.
Attachment #9007489 - Flags: review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d0f8348cdb6
Part 1: Change nsTable*Frame::Get*BorderWidth() return values from nscoord to BCPixelSize. r=dbaron
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8c95278f139
Part 2: Rename p2t to d2a (app units per device pixel). r=dbaron
https://hg.mozilla.org/mozilla-central/rev/6d0f8348cdb6
https://hg.mozilla.org/mozilla-central/rev/c8c95278f139
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.