1397138 - Adding suggestions must not unfuzzy strings

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

See the link - the string displayed are actually suggested, even if the are filtered as fuzzy (and counted in the sum pie chart on the top as fuzzy). I have noticed this happens after a next sync.

Likely STR:
1) Have a fuzzy string/imported string.
2) Add a suggestion for it and do not approve or reject it.
3) Wait for a next sync adding new strings (maybe these need to be fuzzy too).
4) Now the imported strings with suggestions from step 2 are counted as fuzzy instead of suggested.

Maybe related to bug 1381852, or can be fixed together with bug 1377969?

Comment 1

[Matjaz Horvat [:mathjazz]]

When a suggestion is added to a fuzzy string, we should keep treating the string as fuzzy to keep Pontoon and VCS in sync.

That means the string should be:
- identified with the yellow color in the string list
- counted as Fuzzy in the stats
- caught by the Fuzzy filter (instead of Suggested)
- using the fuzzy translation as the "active translation"

Related to the last point, we should change the order of the History tab: fuzzy strings should be displayed above suggestions.

Comment 3

[Matjaz Horvat [:mathjazz]]

I bumbped into this issue while I was working on bug 1481175, so I included the fix in that PR:
https://github.com/mozilla/pontoon/pull/1072/commits/72b7c409c37316f5a10b667b2cb340f93a9795d5

Comment 4

[Matjaz Horvat [:mathjazz]]

Fixed:
https://github.com/mozilla/pontoon/commit/6db15d17c9707ac1340119acc0e67dba7839fac0