1397169 - Clicking on an URL navigate the page inside the toolbox

Status: RESOLVED FIXED

(DevTools :: DOM, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce: 

1. Open the console
2. Evaluate the following code `window.mozilla = "http://mozilla.org"`
3. Go to the DOM panel
4. Search for "mozilla" in the filter input
5. Click on the "http://mozilla.org" link

Expected results:
The link is opened in a new tab

Actual results:
The DOM panel is replaced with the "http://mozilla.org" website

---

This is due to the fact that Reps rely on a openLink callback to open links. If the callback is not set, a simple <a> link is created, and clicking on it navigates to the page in place (we do want this behavior for the JSON panel).

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1397169 - Properly implement openLink;

Review commit: https://reviewboard.mozilla.org/r/176838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176838/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8904996 [details]
Bug 1397169 - Properly implement openLink;

https://reviewboard.mozilla.org/r/176838/#review181750

I see. It's an another similar openLink issue. Thanks for your quick fix. Honza!

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the review Ricky!

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de7570a6289b
Properly implement openLink; r=rickychien

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/de7570a6289b