Clicking on an URL navigate the page inside the toolbox

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools: DOM
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: nchevobbe, Assigned: Honza)

Tracking

Trunk
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
Steps to reproduce: 

1. Open the console
2. Evaluate the following code `window.mozilla = "http://mozilla.org"`
3. Go to the DOM panel
4. Search for "mozilla" in the filter input
5. Click on the "http://mozilla.org" link

Expected results:
The link is opened in a new tab

Actual results:
The DOM panel is replaced with the "http://mozilla.org" website

---

This is due to the fact that Reps rely on a openLink callback to open links. If the callback is not set, a simple <a> link is created, and clicking on it navigates to the page in place (we do want this behavior for the JSON panel).
(Assignee)

Updated

8 months ago
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8904996 [details]
Bug 1397169 - Properly implement openLink;

https://reviewboard.mozilla.org/r/176838/#review181750

I see. It's an another similar openLink issue. Thanks for your quick fix. Honza!
Attachment #8904996 - Flags: review?(rchien) → review+
(Assignee)

Comment 3

8 months ago
Thanks for the review Ricky!

Honza

Comment 4

8 months ago
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de7570a6289b
Properly implement openLink; r=rickychien
https://hg.mozilla.org/mozilla-central/rev/de7570a6289b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1397137
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1389486
You need to log in before you can comment on or make changes to this bug.