Closed Bug 1397182 Opened 3 years ago Closed 3 years ago

Extend reader mode telemetry probes that will expire in 58

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

Details

Attachments

(1 file)

* READER_MODE_DOWNLOAD_RESULT expires in version 58.0a1 (watched by firefox-dev@mozilla.org, gijs@mozilla.com) - The result of trying to download a document to show in reader view (0=Success, 1=Error XHR, 2=Error no document)
* READER_MODE_PARSE_RESULT expires in version 58.0a1 (watched by firefox-dev@mozilla.org, gijs@mozilla.com) - The result of trying to parse a document to show in reader view (0=Success, 1=Error too many elements, 2=Error in worker, 3=Error no article)

These probes are still necessary to be able to determine if changes to reader mode regress/improve performance "in the wild".
Attachment #8904927 - Flags: review?(rweiss)
I'm switching to expires=never because this is the 4th time we'd be bumping things, and we've been bumping the probe for 2 years now, it's opt-in, and it collects very little information, on the whole, so I think our lives would just be simpler if we stopped bumping it and just made it not expire.
:Gijs, are you the person responsible for keeping track of this measurement in the wild?  As long as there is a person accountable for the permanent probe, this will be an easy r+.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Rebecca Weiss from comment #3)
> :Gijs, are you the person responsible for keeping track of this measurement
> in the wild? 

Yes.
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8904927 [details]
Bug 1397182 - stop expiring reader mode telemetry probes,

https://reviewboard.mozilla.org/r/176726/#review183582
Attachment #8904927 - Flags: review?(rweiss) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d77458b0217a
stop expiring reader mode telemetry probes, r=rweiss+418169
https://hg.mozilla.org/mozilla-central/rev/d77458b0217a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.