1397266 - [Overlay] The Sync progress is checked even if the sign up process was not (properly) completed

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 56.0b9 build1 (20170903140023)

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- Mac OS X 10.11.6

[Steps to reproduce]:
1. Launch Firefox with a clean profile
2. Open a new tab and cleck the FoxHead icon to start the tour
3. Go to the Sync section from the navigation bar and click the Next button without filling the email address (or after typing an invalid email address)
- inspect the tour navigation bar 

[Expected result]:
- The Sync progress isn't marked as completed (by a green check mark) until the sign up process is properly finished
- The Next button becomes active only when the email field is properly filled

[Actual result]:
- The Sync progress is marked as completed with the green check mark even if the email field is not filled or if an invalid email address is entered
- The Next button is active even if the email field isn't (properly) filled

[Regression range]:
- The issue is reproducible all the way back to 56.0a1 (2017-07-20), when bug 1356473 was fixed, so this issue is not a regression

Comment 1

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

See the spec doc from https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14.

Comment 2

[Francis Lee [:frlee]]

this is by design, remove whiteboard tag due to its INVALID

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Francis Lee [:frlee] from comment #2)
> this is by design, remove whiteboard tag due to its INVALID

Based on the spec doc mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 (see the Navigation & progress section), "in some cases like Sync and default browser, you have to actually complete the sign up or change the setting in order to get the check mark. For others, Private Browsing for example, simply opening the page constitutes completeness." - so the by design the user must complete the sign up process before the check mark is displayed. 
Is the above spec doc out pf date? If yes, please provide us an updated version and tag https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 as obsolete. 
Thank you!

Comment 4

[Fischer [:Fischer]]

(In reply to Iulia Cristescu, QA [:JuliaC] from comment #3)
> (In reply to Francis Lee [:frlee] from comment #2)
> > this is by design, remove whiteboard tag due to its INVALID
> 
> Based on the spec doc mentioned in
> https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 (see the Navigation
> & progress section), "in some cases like Sync and default browser, you have
> to actually complete the sign up or change the setting in order to get the
> check mark. For others, Private Browsing for example, simply opening the
> page constitutes completeness." - so the by design the user must complete
> the sign up process before the check mark is displayed. 
> Is the above spec doc out pf date? If yes, please provide us an updated
> version and tag https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 as
> obsolete. 
> Thank you!
The specs has changed from the months. This change was made during one meeting[1], thanks.

Comment 5

[Fischer [:Fischer]]

Add the missing link:
(In reply to Fischer [:Fischer] from comment #4)
> (In reply to Iulia Cristescu, QA [:JuliaC] from comment #3)
> > (In reply to Francis Lee [:frlee] from comment #2)
> > > this is by design, remove whiteboard tag due to its INVALID
> > 
> > Based on the spec doc mentioned in
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 (see the Navigation
> > & progress section), "in some cases like Sync and default browser, you have
> > to actually complete the sign up or change the setting in order to get the
> > check mark. For others, Private Browsing for example, simply opening the
> > page constitutes completeness." - so the by design the user must complete
> > the sign up process before the check mark is displayed. 
> > Is the above spec doc out pf date? If yes, please provide us an updated
> > version and tag https://bugzilla.mozilla.org/show_bug.cgi?id=1354046#c14 as
> > obsolete. 
> > Thank you!
> The specs has changed from the months. This change was made during one meeting[1], thanks.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1381351#c4

Comment 6

[Francis Lee [:frlee]]

hi Michael,

could you please update the spec?

thank you very much