Closed
Bug 1397287
Opened 7 years ago
Closed 7 years ago
[nosdk] Stop using addon-sdk OS in devtools/shared/system.js
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
(Whiteboard: [nosdk])
Attachments
(8 files)
59 bytes,
text/x-review-board-request
|
sole
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
Details |
See http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/devtools/shared/system.js#12 > loader.lazyRequireGetter(this, "OS", "resource://gre/modules/commonjs/node/os.js"); This is mapped to http://searchfox.org/mozilla-central/source/addon-sdk/source/lib/node/os.js
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8905057 [details] Bug 1397287 - remove usage of addon-sdk node/os helper in devtools/shared/system; https://reviewboard.mozilla.org/r/176866/#review181844 Thank you! Looking good
Attachment #8905057 -
Flags: review?(spenades) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90099274b157 remove usage of addon-sdk node/os helper in devtools/shared/system;r=sole
Updated•7 years ago
|
Flags: qe-verify-
Target Milestone: --- → Firefox 57
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/90099274b157
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8905548 -
Flags: review?(spenades)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•