Closed
Bug 1397343
Opened 7 years ago
Closed 7 years ago
Lazy load inspector front dependencies
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 3 open bugs)
Details
Attachments
(1 file)
A bunch of dependencies could be lazy loaded from inspector fronts, especially dependencies that are only used in some request that aren't necessarely used a lot: http://searchfox.org/mozilla-central/source/devtools/shared/fronts/
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8905405 -
Flags: review?(pbrosset)
Assignee | ||
Comment 3•7 years ago
|
||
Sorry I mixed up bugs while pushing to mozreview... Also, this patch depends on bug 1396600 as it modify the same files.
Depends on: 1396600
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7167d69b67e4f85c4e164c81ca6b608c91470029
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8905405 [details] Bug 1397343 - Lazy load dependencies from inspector front modules. https://reviewboard.mozilla.org/r/177200/#review182240 Looks good to me. Do you mind writing some docs about this though? I remember you were already on a lazy-loading frenzy last year, and now again. So we need a way for people to know what to lazy load and what not so that we don't have to do this kind of things every X months when our tools become slow again. I remember Julian wrote a loader-related article last year: https://gist.github.com/juliandescottes/169f3a57e1441542565b Maybe adding to this some guidelines about when to lazy load and how would be great. And then you can add this as a markdown file inside /devtools/docs so that it can be generated as part of our docs on http://docs.firefox-dev.tools Also sending an email about it on the mailing list would be helpful.
Attachment #8905405 -
Flags: review?(pbrosset) → review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/846e32a850c9 Lazy load dependencies from inspector front modules. r=pbro
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/846e32a850c9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Assignee: nobody → poirot.alex
You need to log in
before you can comment on or make changes to this bug.
Description
•