Closed
Bug 1397356
Opened 7 years ago
Closed 7 years ago
Remove unnecessary custom testharnessreport.js file
Categories
(Testing :: web-platform-tests, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(1 file)
864 bytes,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
In IRC jgraham told me that this file was no longer necessary (and it was getting in the way of me running manual web-platform-tests. http://logs.glob.uno/?c=mozilla%23content&s=6+Sep+2017&e=6+Sep+2017#c460418
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8905122 -
Flags: review?(james)
Comment 2•7 years ago
|
||
Comment on attachment 8905122 [details] [diff] [review] Remove unnecessary custom testharnessreport.js file Review of attachment 8905122 [details] [diff] [review]: ----------------------------------------------------------------- We should perhaps leave a file there, just to avoid resources unexpectedly failing to load at all, but it's not a big deal.
Attachment #8905122 -
Flags: review?(james) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to James Graham [:jgraham] from comment #2) > Comment on attachment 8905122 [details] [diff] [review] > Remove unnecessary custom testharnessreport.js file > > Review of attachment 8905122 [details] [diff] [review]: > ----------------------------------------------------------------- > > We should perhaps leave a file there, just to avoid resources unexpectedly > failing to load at all, but it's not a big deal. I left the file there (didn't delete it) for that reason.
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0bfc1c566350 Remove unnecessary custom testharnessreport.js file, r=jgraham
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0bfc1c566350
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 6•7 years ago
|
||
This file seems to have re-appeared in tree after I removed it in this patch. Do you know why it re-appeared and can we re-disappear it (but for good this time?)
Flags: needinfo?(james)
Comment 7•7 years ago
|
||
Looks like the import script recreates it. Sorry! I'll fix that during the next update.
Assignee | ||
Comment 8•6 years ago
|
||
Seems to still be here: https://hg.mozilla.org/mozilla-central/file/60540711465d/testing/web-platform/tests/resources
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/92c0cfb8dd3f Don't copy testharnessreport in sync, a=testonly
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/92c0cfb8dd3f
Updated•6 years ago
|
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•