Closed Bug 1397356 Opened 4 years ago Closed 4 years ago

Remove unnecessary custom testharnessreport.js file

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file)

In IRC jgraham told me that this file was no longer necessary (and it was getting in the way of me running manual web-platform-tests.

http://logs.glob.uno/?c=mozilla%23content&s=6+Sep+2017&e=6+Sep+2017#c460418
Comment on attachment 8905122 [details] [diff] [review]
Remove unnecessary custom testharnessreport.js file

Review of attachment 8905122 [details] [diff] [review]:
-----------------------------------------------------------------

We should perhaps leave a file there, just to avoid resources unexpectedly failing to load at all, but it's not a big deal.
Attachment #8905122 - Flags: review?(james) → review+
(In reply to James Graham [:jgraham] from comment #2)
> Comment on attachment 8905122 [details] [diff] [review]
> Remove unnecessary custom testharnessreport.js file
> 
> Review of attachment 8905122 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We should perhaps leave a file there, just to avoid resources unexpectedly
> failing to load at all, but it's not a big deal.

I left the file there (didn't delete it) for that reason.
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bfc1c566350
Remove unnecessary custom testharnessreport.js file, r=jgraham
https://hg.mozilla.org/mozilla-central/rev/0bfc1c566350
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
This file seems to have re-appeared in tree after I removed it in this patch.

Do you know why it re-appeared and can we re-disappear it (but for good this time?)
Flags: needinfo?(james)
Looks like the import script recreates it. Sorry! I'll fix that during the next update.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92c0cfb8dd3f
Don't copy testharnessreport in sync, a=testonly
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.