Closed
Bug 1397379
Opened 7 years ago
Closed 7 years ago
getStringPref in clicktoplay-rollout addon throws for new profiles
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox55 | --- | unaffected |
firefox56 | ? | fixed |
firefox57 | --- | fixed |
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Gijs
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
getStringPref in clicktoplay-rollout addon throws for new profiles, because PREF_COHORT_NAME doesn't have a default value in all.js or firefox.js, and the function call didn't specify a default fallback. This started happening from the conversion on bug 1357517 (see specifically bug 1357517 comment 63). Preferences.jsm's Preferences.get() has an implicit default value, but getStringPref doesn't. [Tracking Requested - why for this release]: needed for proper Flash Click-to-Play rollout on 56
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8905169 -
Flags: review?(mcastelluccio)
Attachment #8905169 -
Flags: review?(gijskruitbosch+bugs)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8905169 [details] Bug 1397379 - getStringPref in clicktoplay-rollout addon throws for new profiles. https://reviewboard.mozilla.org/r/176958/#review181962 rs=me Sorry for missing this in the reviews in bug 1357517. :-(
Attachment #8905169 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8905169 -
Flags: review?(mcastelluccio)
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/135933a19783 getStringPref in clicktoplay-rollout addon throws for new profiles. r=Gijs
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8905169 [details] Bug 1397379 - getStringPref in clicktoplay-rollout addon throws for new profiles. Approval Request Comment [Feature/Bug causing the regression]: bug 1357517 [User impact if declined]: new profiles won't get flash as click-to-play [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: doesn't apply, it's only used for the gradual rollout on beta and release [Needs manual test from QE? If yes, steps to reproduce]: not in advance, this will be done implictly through bug 1390703 and bug 1390705 (if we have to re-test them in 56) [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: small bug fix only related to the flash clicktoplay rollout [String changes made/needed]: none
Attachment #8905169 -
Flags: approval-mozilla-beta?
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/135933a19783
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 6•7 years ago
|
||
Comment on attachment 8905169 [details] Bug 1397379 - getStringPref in clicktoplay-rollout addon throws for new profiles. Good to fix this so that our tests on 56 rollout will work.
Attachment #8905169 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/765771f59ef1
You need to log in
before you can comment on or make changes to this bug.
Description
•