All users were logged out of Bugzilla on October 13th, 2018

Provide helper function to obtain a BuildReader

RESOLVED FIXED in Firefox 57

Status

RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla57

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

a year ago
This is needed for bug 1383880. But it's something I've wanted to do for a while to cut down on DRY violations.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8905202 [details]
Bug 1397406 - Don't mark finder as a protected attribute;

https://reviewboard.mozilla.org/r/176986/#review182040
Attachment #8905202 - Flags: review?(dustin) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8905203 [details]
Bug 1397406 - Add Repository method to determine if working directory clean;

https://reviewboard.mozilla.org/r/176988/#review182044
Attachment #8905203 - Flags: review?(dustin) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8905209 [details]
Bug 1397406 - Use BuildReader helper in `mach test`;

https://reviewboard.mozilla.org/r/176992/#review182056
Attachment #8905209 - Flags: review?(dustin) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8905204 [details]
Bug 1397406 - Add a helper function to retrieve a BuildReader;

https://reviewboard.mozilla.org/r/176990/#review182058
Attachment #8905204 - Flags: review?(dustin) → review+

Comment 10

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/caccc7951f5b
Don't mark finder as a protected attribute; r=dustin
https://hg.mozilla.org/integration/autoland/rev/da68a5ff28d0
Add Repository method to determine if working directory clean; r=dustin
https://hg.mozilla.org/integration/autoland/rev/e9416a307987
Add a helper function to retrieve a BuildReader; r=dustin
https://hg.mozilla.org/integration/autoland/rev/56d353e23439
Use BuildReader helper in `mach test`; r=dustin

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.