Closed
Bug 1397406
Opened 7 years ago
Closed 7 years ago
Provide helper function to obtain a BuildReader
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(4 files)
This is needed for bug 1383880. But it's something I've wanted to do for a while to cut down on DRY violations.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8905202 [details] Bug 1397406 - Don't mark finder as a protected attribute; https://reviewboard.mozilla.org/r/176986/#review182040
Attachment #8905202 -
Flags: review?(dustin) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8905203 [details] Bug 1397406 - Add Repository method to determine if working directory clean; https://reviewboard.mozilla.org/r/176988/#review182044
Attachment #8905203 -
Flags: review?(dustin) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8905209 [details] Bug 1397406 - Use BuildReader helper in `mach test`; https://reviewboard.mozilla.org/r/176992/#review182056
Attachment #8905209 -
Flags: review?(dustin) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8905204 [details] Bug 1397406 - Add a helper function to retrieve a BuildReader; https://reviewboard.mozilla.org/r/176990/#review182058
Attachment #8905204 -
Flags: review?(dustin) → review+
Comment 10•7 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/caccc7951f5b Don't mark finder as a protected attribute; r=dustin https://hg.mozilla.org/integration/autoland/rev/da68a5ff28d0 Add Repository method to determine if working directory clean; r=dustin https://hg.mozilla.org/integration/autoland/rev/e9416a307987 Add a helper function to retrieve a BuildReader; r=dustin https://hg.mozilla.org/integration/autoland/rev/56d353e23439 Use BuildReader helper in `mach test`; r=dustin
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/caccc7951f5b https://hg.mozilla.org/mozilla-central/rev/da68a5ff28d0 https://hg.mozilla.org/mozilla-central/rev/e9416a307987 https://hg.mozilla.org/mozilla-central/rev/56d353e23439
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•