Closed
Bug 1397460
Opened 7 years ago
Closed 7 years ago
Don't throw for a failure in cpows_child.js
Categories
(Core :: DOM: Content Processes, enhancement)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
test_cpows.xul runs some code in the child (which can actually be same process), via cpows_child.js. Testing in cpows_child.js is done by calling a function ok() that sends an async "cpows:fail" message if the test fails. However, after it does that, it throws an exception, which just causes the test to hang forever. I think it is okay to just not throw the exception. I tested it, and we still get a failure, but the test runs to completion.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8905255 [details] Bug 1397460 - Don't throw for a failure in cpows_child.js. https://reviewboard.mozilla.org/r/177056/#review182060
Attachment #8905255 -
Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5aa81a626da Don't throw for a failure in cpows_child.js. r=billm
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a5aa81a626da
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•