Closed Bug 1397500 Opened 7 years ago Closed 7 years ago

stylo: disable the ActiveElementUsesStyle for stylo

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: bholley, Assigned: bholley)

Details

Attachments

(1 file)

Per bug 1397434, we'd need to develop some machinery to support it. That probably doesn't block, but we should at least prevent incorrect behavior.
MozReview-Commit-ID: 20aqaFv9fxE
Attachment #8905280 - Flags: review?(emilio)
Comment on attachment 8905280 [details] [diff] [review]
Disable the ActiveElementUsesStyle optimization for stylo. v1

Review of attachment 8905280 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with a bug on file.

Thanks!

::: gfx/layers/apz/util/ActiveElementManager.cpp
@@ +169,5 @@
>      return false;
>    }
> +  nsStyleSet* styleSet = pc->StyleSet()->GetAsGecko();
> +  if (!styleSet) {
> +      AEM_LOG("Element %p uses Servo style backend, assuming dependence on active state\n", e);

File a followup, mention it in a comment here?
Attachment #8905280 - Flags: review?(emilio) → review+
Comment on attachment 8905280 [details] [diff] [review]
Disable the ActiveElementUsesStyle optimization for stylo. v1

Review of attachment 8905280 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/apz/util/ActiveElementManager.cpp
@@ +169,5 @@
>      return false;
>    }
> +  nsStyleSet* styleSet = pc->StyleSet()->GetAsGecko();
> +  if (!styleSet) {
> +      AEM_LOG("Element %p uses Servo style backend, assuming dependence on active state\n", e);

s/e/aElement

Otherwise the change to this file looks good to me.
Attachment #8905280 - Flags: review+ → review?(emilio)
Whoops. Didn't mean to override the r+ flag there.
Comment on attachment 8905280 [details] [diff] [review]
Disable the ActiveElementUsesStyle optimization for stylo. v1

Review of attachment 8905280 [details] [diff] [review]:
-----------------------------------------------------------------

Err, never mind about the followup (you filed a different bug to remove it), but please mention the bug to implement the optimization from there.
Attachment #8905280 - Flags: review?(emilio) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7efa30ab3893
Disable the ActiveElementUsesStyle optimization for stylo. r=emilio
https://hg.mozilla.org/mozilla-central/rev/7efa30ab3893
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.