Closed
Bug 1397506
Opened 7 years ago
Closed 7 years ago
IPDL unit tests are broken (TestAsyncReturns.cpp doesn't compile)
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
899 bytes,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
I'm guessing you broke this Kris?
Attachment #8905282 -
Flags: review?(kmaglione+bmo)
Comment 1•7 years ago
|
||
Comment on attachment 8905282 [details] [diff] [review] patch Review of attachment 8905282 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Bill McCloskey (:billm) from comment #0) > I'm guessing you broke this Kris? Hm. I guess so, but why didn't the tests fail on check-in? r=me, but it might make more sense for the resolver to take copyable args by value in the tuple case.
Attachment #8905282 -
Flags: review?(kmaglione+bmo) → review+
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bfea6090979c IPDL unit test fix (r=kmag)
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bfea6090979c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•