1397580 - Remove some write-only variable assignments in HTMLEditor::DoInsertHTMLWithContext()

Status: NEW

(Core :: DOM: Editor, enhancement, P5)

Description

[(no longer active)]

No code ever reads the result of these assignments.

Comment 1

[(no longer active)]

Attachment: Remove some write-only variable assignments in HTMLEditor::DoInsertHTMLWithContext()

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Comment on attachment 8905342 [details] [diff] [review]
Remove some write-only variable assignments in HTMLEditor::DoInsertHTMLWithContext()

>@@ -553,20 +553,16 @@ HTMLEditor::DoInsertHTMLWithContext(const nsAString& aInputString,
>               bDidInsert = true;
>               insertedContextParent = parent;
>               lastInsertNode = GetChildAt(parentNode, offsetOfNewNode);
>             }
>           }
>           curNode = parent;
>         }
>       }
>-      if (lastInsertNode) {
>-        parentNode = GetNodeLocation(lastInsertNode, &offsetOfNewNode);
>-        offsetOfNewNode++;
>-      }

I don't understand this change. Here is in a for loop:
https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/editor/libeditor/HTMLEditorDataTransfer.cpp#440,565

And both parentNode may be referred in next time.
https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/editor/libeditor/HTMLEditorDataTransfer.cpp#440,460,462,483-484

So, looks like that this breaks something.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

I forget to omit |both|. only parentNode may be referred.

Comment 4

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.