Closed
Bug 1397583
Opened 7 years ago
Closed 7 years ago
With compact UI density, urlbar animations for Pocket and bookmark star are in the wrong place (offset to the right of the normal icon)
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
(Keywords: regression, Whiteboard: [reserve-photon-animation])
Attachments
(1 file)
When the UI density is compact, the bookmark star and Pocket animations are shifted to the right, like they were in bug 1390182. It doesn't look like the related CSS handles :root[uidensity] specially, for margins and such, so maybe it should? I noticed this while working on bug 1397278.
Assignee | ||
Updated•7 years ago
|
Summary: urlbar animations for Pocket and bookmark star are in the wrong place (offset to the right of the normal icon) → With compact UI density, urlbar animations for Pocket and bookmark star are in the wrong place (offset to the right of the normal icon)
Updated•7 years ago
|
Whiteboard: [photon-animation][triage]
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P4
QA Contact: stefan.georgiev
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Updated•7 years ago
|
Flags: needinfo?(jaws)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This is an easy fix, and I'm familiar with this CSS now, so I went ahead and made it.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8905620 [details] Bug 1397583 - With compact UI density, urlbar animations for Pocket and bookmark star are in the wrong place (offset to the right of the normal icon). https://reviewboard.mozilla.org/r/177418/#review182436 Thanks for fixing this!
Attachment #8905620 -
Flags: review?(jaws) → review+
Updated•7 years ago
|
Flags: needinfo?(jaws)
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bb535da41e5 With compact UI density, urlbar animations for Pocket and bookmark star are in the wrong place (offset to the right of the normal icon). r=jaws
Updated•7 years ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment 6•7 years ago
|
||
I see this is marked as blocking bug 1387077 -- not sure what that signifies or if that's correct, but this regressed much more recently than when bug 1387077 landed. As identified on dupe bug 1397903 (via mozregression), this compact-density issue is a regression from bug 1388589. Marking as such. (I'm glad to see a fix has landed already - thanks for the fast work!)
Blocks: 1388589
Keywords: regression
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6bb535da41e5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Iteration: --- → 57.3 - Sep 19
Priority: P4 → P1
Comment 8•7 years ago
|
||
I was able to reproduce the issue with compact UI density using Nightly build: 20170906100107. Build ID 20170908100218 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 This bug is Verified with latest Nightly 57.0a1.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Flags: qe-verify+
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•