Closed Bug 1397609 Opened 2 years ago Closed 2 years ago

Fix a11y of bookmark star and Pocket urlbar buttons

Categories

(Firefox :: Disability Access, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

See bug 1395178 comment 8 and on.
Marco, could you please try the try build?  Here's the archive directory, although I've recently noticed that builds often don't appear here anymore: https://archive.mozilla.org/pub/firefox/try-builds/dwillcoxon@mozilla.com-29785c2a92c98deecabf11d6bd3fc1fc43a8ba1a/

If they don't, I think you can click individual builds on treeherder and from there get build artifacts, from the Job Details tab, or the Inspect Task menu item in the ellipsis menu, or something?  I'm sure you already know this, I'm just trying to decrease turnaround time in case you don't since we're in very different time zones.  Here's the treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29785c2a92c9
Flags: needinfo?(mzehe)
The try builds didn't appear in the artifacts directory, but the jobs had links to target files. However, the builds were broken in a major way, every tab I opened immediately crashed no matter which site I loaded.

However, I looked at your patch, and am confident this is the right markup.
Flags: needinfo?(mzehe)
Comment on attachment 8905363 [details]
Bug 1397609 - Fix a11y of bookmark star and Pocket urlbar buttons.

https://reviewboard.mozilla.org/r/177154/#review182282

rs=me based on code inspection and Marco's comment. Thanks!
Attachment #8905363 - Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7e0c0b8a5c13
Fix a11y of bookmark star and Pocket urlbar buttons. r=Gijs
Thanks Marco.  I should have mentioned to feel free to review the code too. :-)
https://hg.mozilla.org/mozilla-central/rev/7e0c0b8a5c13
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
This issue is verified fixed using Firefox 57.0b13 (BuildId:20171030163911) with NVDA on Windows 10 64bit.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.