Closed
Bug 1397628
Opened 7 years ago
Closed 7 years ago
Don't auto-atomize strings passed from script
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
2.22 KB,
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
If you pass a string from script to an IDL method that takes an nsIAtom, XPConnect will automagically atomize the string for you. But nsIAtom is no longer scriptable (see the blockers for bug 1392883, especially bug 1396694). So the code to convert can be removed.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8905372 -
Flags: review?(kmaglione+bmo)
Comment 2•7 years ago
|
||
Comment on attachment 8905372 [details] [diff] [review] Don't auto-atomize strings passed from script Review of attachment 8905372 [details] [diff] [review]: ----------------------------------------------------------------- It seems like this might actually be useful with non-scriptable atoms, if it were actually possible to make methods that take atom args scriptable. Probably doesn't matter at this point, though, and it's definitely nice to get rid of this overhead.
Attachment #8905372 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b2a93197d2ba3a04d05644c55f3432c2dba5866 Bug 1397628 - Don't auto-atomize strings passed from script. r=kmag.
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b2a93197d2b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•