Closed Bug 1397628 Opened 3 years ago Closed 3 years ago

Don't auto-atomize strings passed from script

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

If you pass a string from script to an IDL method that takes an nsIAtom,
XPConnect will automagically atomize the string for you.

But nsIAtom is no longer scriptable (see the blockers for bug 1392883,
especially bug 1396694). So the code to convert can be removed.
Attachment #8905372 - Flags: review?(kmaglione+bmo)
Comment on attachment 8905372 [details] [diff] [review]
Don't auto-atomize strings passed from script

Review of attachment 8905372 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like this might actually be useful with non-scriptable atoms, if it were actually possible to make methods that take atom args scriptable.

Probably doesn't matter at this point, though, and it's definitely nice to get rid of this overhead.
Attachment #8905372 - Flags: review?(kmaglione+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/9b2a93197d2b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.