1397670 - Disable unused Hawk credentials

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, enhancement, P1)

Description

[Ed Morley [:emorley]]

As part of bug 1349182, we're winding down the ability to submit jobs via the REST API.

There are many hawk credentials that have been issued that are already not being used any more due to people switching to Pulse, submitting via taskcluster or else decommissioning their system.

The list of hawk credentials being used in the last 7 days can be found using...

Prod:
https://insights.newrelic.com/accounts/677903/explorer/events?eventType=Transaction&filters=%255B%257B%2522key%2522%253A%2522appName%2522%252C%2522value%2522%253A%2522treeherder-prod%2522%257D%255D&duration=604800000&facet=hawk_client_id

(Currently only: autophone, hasal-dev, awfy)

Stage:
https://insights.newrelic.com/accounts/677903/explorer/events?eventType=Transaction&filters=%255B%257B%2522key%2522%253A%2522appName%2522%252C%2522value%2522%253A%2522treeherder-stage%2522%257D%255D&duration=604800000&facet=hawk_client_id

(Currently only: autophone_bclary, hasal-dev)

Comment 1

[Ed Morley [:emorley]]

The following Hawk client IDs (combined Treeherder stage+prod list) have not been used in the last 7 days (that's as far back as New Relic Insights goes unfortunately):
- awsy (believe due to bug 1272113)
- cloud-services-qa
- gaia-taskcluster (since it was only used for now EOL Firefox ESR iirc)
- mozauto
- mozilla-taskcluster (since it was only used for now EOL Firefox ESR iirc)
- mozreviewci
- pulse_actions (since it has been decommissioned in bug 1379172)
- raptor
- servo
- servo-perf
- test-based-ui
- WebRTC_lab

To the people CCed - if your client ID listed there is still required, please comment :-)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Ed Morley [:emorley] from comment #1)
> - mozauto

Please don't remove it yet. We are about to re-enable our tests for 56 and 57 soon. For details see bug 1386628.

Comment 3

[Cameron Dawson [:camd]]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> (In reply to Ed Morley [:emorley] from comment #1)
> > - mozauto
> 
> Please don't remove it yet. We are about to re-enable our tests for 56 and
> 57 soon. For details see bug 1386628.

Henrik--  Is there any way you could migrate to using TaskCluster or Pulse to submit your results instead of the API?  We're hoping to phase out API submission at some point before too long.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Cameron Dawson [:camd] from comment #3)
> (In reply to Henrik Skupin (:whimboo) from comment #2)
> > (In reply to Ed Morley [:emorley] from comment #1)
> > > - mozauto
> > 
> > Please don't remove it yet. We are about to re-enable our tests for 56 and
> > 57 soon. For details see bug 1386628.
> 
> Henrik--  Is there any way you could migrate to using TaskCluster or Pulse
> to submit your results instead of the API?  We're hoping to phase out API
> submission at some point before too long.

Most likely not without a PI request. I have no time for that system right now, but we were asked to re-enable it. We might stop it again by December 1st, and don't bring it up again. If that time is fine for you, all set. Otherwise David Durst, or someone else might have to take a look.

Comment 5

[Cameron Dawson [:camd]]

I'm sure that time frame is fine.  I don't see us disabling API submissions before the end of the year.  If we do decide to do so, then we will do our best to contact stakeholders like you via bug 1349182.

Thanks! :)

Comment 6

[Nils Ohlmeier [:drno]]

(In reply to Ed Morley [:emorley] from comment #1)
> - WebRTC_lab

Feel free to remove/disable as needed.

Comment 7

[Ed Morley [:emorley]]

I've confirmed the following client_ids from comment 1 were still not in use over the last 7 days, and deactivated them:
- awsy
- cloud-services-qa
- gaia-taskcluster
- mozilla-taskcluster
- mozreviewci
- raptor
- servo
- servo-perf
- test-based-ui
- WebRTC_lab

On prod this leaves just:
- autophone
- awfy
- hasal-dev
- mozauto
- pulse_actions

I believe the last two will go away due to already-planned decomissioning. This leaves 3 others to migrate to Pulse.

Comment 8

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #7)
> On prod this leaves just:
> - autophone
> - awfy
> - hasal-dev
> - mozauto
> - pulse_actions

Note to self: Checking the last 7 days now shows only {autophone, mozauto, awfy} being used. Check back at some point in the future to confirm {pulse_actions, hasal-dev} can now be removed.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Ed Morley [:emorley] from comment #8)
> Note to self: Checking the last 7 days now shows only {autophone, mozauto,
> awfy} being used. Check back at some point in the future to confirm

FYI mozauto will be in use at latest until EOL of SCL3 which should be Aug/Sep this year.

Comment 10

[Ed Morley [:emorley]]

I've disabled pulse_actions (since decommissioned in bug 1379172) and hasal-dev (since no longer submitting to Treeherder, see bug 1428792 comment 0).

(In reply to Henrik Skupin (:whimboo) from comment #9)
> FYI mozauto will be in use at latest until EOL of SCL3 which should be
> Aug/Sep this year.

Ah thank you. Is there a bug filed for the decom/transitioning to other services, that I can mark blocking bug 1395337?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Ed Morley [:emorley] from comment #10)
> Ah thank you. Is there a bug filed for the decom/transitioning to other
> services, that I can mark blocking bug 1395337?

You can take bug 1386628 for that.