If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update the notification bar appearances after M-C bug 1363056

RESOLVED FIXED in Thunderbird 57.0

Status

Thunderbird
Theme
RESOLVED FIXED
18 days ago
18 days ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 57.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

18 days ago
Bug 1363056 updated the notification bars for Photon.

Now all platforms have the same colors and not the system appearances.
(Assignee)

Comment 1

18 days ago
Created attachment 8905429 [details] [diff] [review]
notification.patch

The most obvious changes are:
Use SVG icons instead of PNG
Use a less glaring yellow for type="warning" notifications

I also removed the gradients/background-images on the Add-ons manager page when installing an extension and when an install fails. They there good with the old in-content colors. Now it's not needed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8905429 - Flags: review?(jorgk)

Comment 2

18 days ago
Created attachment 8905461 [details]
1397680.png - screenshot of attachment paper clips

This looks nice, but I have some nits.

The paper clip on the notification bar and the one on the in-content preferences are a little inconsistent. On the notification bar, the open ends need to go a little further up, especially on the inside.

Even if this is fixed, the icon is now inconsistent with the icon on the "Attach" button, so I ask myself whether the new SVG is required when we had compose-toolbar.svg#attach. What's the plan for this file in general? Are we going to split that into individual files little by little?
(Assignee)

Comment 3

18 days ago
Created attachment 8905574 [details] [diff] [review]
notification.patch

Made the attach icons more similar.

I'm planning until TB 59 to use single icon files for the buttons either from Monterail or from ntim (photon icons). Until then it can be that the icons look different (then the Attach button would use the same icon as the notification bar).
Attachment #8905461 - Attachment is obsolete: true
Attachment #8905574 - Flags: review?(jorgk)

Updated

18 days ago
Attachment #8905429 - Attachment is obsolete: true
Attachment #8905429 - Flags: review?(jorgk)

Comment 4

18 days ago
Comment on attachment 8905574 [details] [diff] [review]
notification.patch

Review of attachment 8905574 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/linux/mail/compose/messengercompose.css
@@ +226,5 @@
>    font-weight: bold;
>  }
>  
>  #attachmentNotificationBox > notification[image="null"] .messageImage {
> +  background-image: url("chrome://messenger/skin/icons/attach.svg");

Please change the file name here, too.
(Assignee)

Comment 5

18 days ago
(In reply to Jorg K (GMT+2) from comment #4)
> Comment on attachment 8905574 [details] [diff] [review]
> notification.patch
> 
> Review of attachment 8905574 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/themes/linux/mail/compose/messengercompose.css
> @@ +226,5 @@
> >    font-weight: bold;
> >  }
> >  
> >  #attachmentNotificationBox > notification[image="null"] .messageImage {
> > +  background-image: url("chrome://messenger/skin/icons/attach.svg");
> 
> Please change the file name here, too.

To what should I change it? This is the correct one.

Comment 6

18 days ago
Right, I got confused. Can I be a big pain? Sorry.

The old paper clip for the preferences had:
2-2-2-2-2-2 pixels.
The new paper clip has:
2-1-2-4-2-1-2
That looks really disproportional. How would
2-1-2-2-2-1-2 look like?

The one in the notification has:
1-1-1-2-1-1-1
Looks OK to me.
(Assignee)

Comment 7

18 days ago
Created attachment 8905665 [details] [diff] [review]
notification.patch

Yeah, this looks better.
Attachment #8905574 - Attachment is obsolete: true
Attachment #8905574 - Flags: review?(jorgk)
Attachment #8905665 - Flags: review?(jorgk)

Comment 8

18 days ago
Comment on attachment 8905665 [details] [diff] [review]
notification.patch

Third time lucky ;-) Thanks for the patience.
Attachment #8905665 - Flags: review?(jorgk) → review+

Comment 9

18 days ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5a6d6607eee5
Update the notification bar appearance after M-C bug 1363056. r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: 18 days ago
Resolution: --- → FIXED

Updated

18 days ago
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.