Closed Bug 1397689 Opened 2 years ago Closed 2 years ago

Should we really run Talos tests against stylo *and* non-stylo?

Categories

(Testing :: Talos, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ochameau, Assigned: jmaher)

References

(Blocks 1 open bug)

Details

(Whiteboard: [stylo])

Attachments

(1 file)

As of today, we run talos suite 3 times when spawning Linux64 builds:
- Non-stylo
- Stylo 
- Stylo-seq

See this try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18f66ee8acba96ba766709fa20274ade782e9df4

May be that's important to keep all the runs on mozilla-central central, but it is very unlikely to be much useful on try...

And while I see talos run being slow and slower to respond, it may be a good time to  save some runs...

In the meantime, would:
try: -b linux64 -t g2-e10s[linux64]
Prevent unnecessary runs ?
I agree, this seems overkill, the default for linux tests should be 'stylo' and by request non-stylo and stylo-seq.

I am not sure how best to do that- I don't think the try syntax would reduce runs; could you look at using |mach try fuzzy| ?
Feel free to stop running Talos on "Stylo-Seq" on any or all repos (even mozilla-central) if you want to conserve resources. While the Talos results for Stylo-Seq are interesting, it is a configuration we are phasing out.
Whiteboard: [stylo]
(In reply to Chris Peterson [:cpeterson] from comment #2)
> Feel free to stop running Talos on "Stylo-Seq" on any or all repos (even
> mozilla-central) if you want to conserve resources. While the Talos results
> for Stylo-Seq are interesting, it is a configuration we are phasing out.

The sequential results are still useful for AWSY, so please don't get rid of those, at least for the next two weeks as we finish grinding down memory usage.
the simplest change, we still run awsy- I didn't disable the threads=1 tests we have for tp6, just the platform stylo-sequential talos:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf1d521dbc480837681bdd94d78dfa552897f29e
Attachment #8905875 - Flags: review?(jryans)
Comment on attachment 8905875 [details] [diff] [review]
do not run talos on linux64-stylo-sequential anymore

Review of attachment 8905875 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, thanks!  There are also some BB pieces for this, should they be cleaned up or ignored?
Attachment #8905875 - Flags: review?(jryans) → review+
I tend to leave buildbot alone until we are 100% done with stuff, otherwise it is a bit of a pain to remove/reconfig, add again/reconfig.  I think once we ship with stylo enabled we could make a great pass on buildbot-configs.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1abd1827146
stop running talos on linux64-stylo-sequential builds. r=jryans
https://hg.mozilla.org/mozilla-central/rev/a1abd1827146
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.