Closed Bug 1397729 Opened 7 years ago Closed 7 years ago

Strings inside cookies dialog are not found when searched

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox55 --- unaffected
firefox56 --- verified
firefox57 --- verified

People

(Reporter: bmaris, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(2 files, 1 obsolete file)

[Affected versions]:
- Firefox beta 56.0b9
- latest Nightly 57.0a1

[Affected platforms]:
- Windows 10 64bit
- macOS 10.12.6
- Ubuntu 16.04 32bit

[Steps to reproduce]:
1. Start Firefox
2. Go to about:preferences
3. Search for "The following cookies"

[Expected result]:
- The search finds the string inside Browser Privacy/History/Use custom settings.../Show Cookies dialog.

[Actual result]:
- No search was found.

[Regression range]:
- This is not a regression since this is reproducible since the feature was first enabled by default (old nightly from 2017-06-16).

[Additional notes]:
- This could not be an isolated case though, other strings from different dialogs can be affected.
Priority: -- → P2
Whiteboard: [photon-preference][triage] → [photon-preference]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: P2 → P1
After investigation, there are some missing searchkeywords under "Use custom settings" section which forgot to add. Missing keywords has been addressed along with some improper tooltips position.
Comment on attachment 8906557 [details]
Bug 1397729 - Strings inside cookies dialog are not found when searched

https://reviewboard.mozilla.org/r/178300/#review183330

Thanks!
Attachment #8906557 - Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b7add087f2b
Strings inside cookies dialog are not found when searched r=mconley
https://hg.mozilla.org/mozilla-central/rev/3b7add087f2b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8906557 [details]
Bug 1397729 - Strings inside cookies dialog are not found when searched

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: minor search usability affected
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: yes, see description
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: minor
[Why is the change risky/not risky?]: minor search usability regression
[String changes made/needed]: none
Attachment #8906557 - Flags: approval-mozilla-beta?
Comment on attachment 8906557 [details]
Bug 1397729 - Strings inside cookies dialog are not found when searched

Minor issue uncovered in QA for this new feature, let's uplift the fix. It should land for beta 12.
Attachment #8906557 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attached patch Patch for beta uplift (obsolete) — Splinter Review
I ported over the patch that landed on m-c to beta tip and have attached it here. I also confirmed that the bug is fixed by following the STR in comment #0.
Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
Please back out 6bc1744c12ee and then land this patch on top of it.
Attachment #8907845 - Attachment is obsolete: true
I verified that the tooltip does appear but only after I change from *Remember history* to *Use custom settings in history*. 

There is no highlighter notifying the user that 'The following cookies' was found inside History and how to reach it. Should I log a new bug on that or reopen this?
Flags: needinfo?(rchien)
Good catch! Please file a new bug for this.
Flags: needinfo?(rchien)
I have reproduced this bug with Nightly 57.0a1 (2017-09-07) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 57.0a1 (64-bit).

Build ID   :   20170913220121
User Agent :   Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170913]
(In reply to Ricky Chien [:rickychien] from comment #13)
> Good catch! Please file a new bug for this.

Logged bug 1399856 for that. Marking this bug as verified since the string actually is found but not highlighted. Verified using latest Firefox 56 beta 12 and latest Nightly 57.0a1 across platforms (Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.