Closed Bug 1397731 Opened 2 years ago Closed 2 years ago

Highlight is not removed from dialogs after searching for something and picking a category from Preferences

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- verified
firefox57 --- verified

People

(Reporter: bogdan_maris, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [photon-preference])

Attachments

(2 files)

[Affected versions]:
- Firefox beta 56.0b9
- latest Nightly 57.0a1

[Affected platforms]:
- Windows 10 64bit
- macOS 10.12.6
- Ubuntu 16.04 32bit

[Steps to reproduce]:
1. Start Firefox
2. Go to about:preferences
3. Search for "Allow"
4. Click one of the Category from the left panel (General)
5. Go to Fonts & Colors and click Advanced... button

[Expected result]:
- Allow string is not highlighted anymore.

[Actual result]:
- Allow string is highlighted.

[Regression range]:
- This is a regression:

Last good revision: 6bf02efb9d13df43e19fc985c4ca7c948b0b1be3
First bad revision: 28bddcbef8e16ff816993386f4ba5c432b17919b
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6bf02efb9d13df43e19fc985c4ca7c948b0b1be3&tochange=28bddcbef8e16ff816993386f4ba5c432b17919b

28bddcbef8e1	Ricky Chien — Bug 1363721 - Make about:preferences sub-dialog content highlightable r=mconley

[Additional notes]:
- Screencast attached showing the issue.
- This is not an isolated case, I also can reproduce this using "the following c" string and quite possibly other.
Flags: needinfo?(rchien)
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> [Additional notes]:
> - This is not an isolated case, I also can reproduce this using "the
> following c" string and quite possibly other.

Ups, that's just bad copy/paste from another bug, please ignore that.
Nice catch!

All sub-dialogs' search highlights should be clear after user cancels the search function.


And we have to make sure

4. Click one of the Category from the left panel (General)

is able to clear the all search highlights.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(rchien) → qe-verify+
Priority: -- → P1
Whiteboard: [photon-preference][triage] → [photon-preference]
Target Milestone: --- → Firefox 57
Comment on attachment 8906652 [details]
Bug 1397731 - Clear Preferences search query after category switchover

https://reviewboard.mozilla.org/r/178370/#review183830

Thanks!
Attachment #8906652 - Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15adab296353
Clear Preferences search query after category switchover r=mconley
https://hg.mozilla.org/mozilla-central/rev/15adab296353
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Can we get an approval request for beta uplift please?
Flags: needinfo?(rchien)
Comment on attachment 8906652 [details]
Bug 1397731 - Clear Preferences search query after category switchover

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1363721
[User impact if declined]: visual issue, not usability affected
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: yes, see description
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: visual issue, not usability affected
[String changes made/needed]: none
Flags: needinfo?(rchien)
Attachment #8906652 - Flags: approval-mozilla-beta?
Comment on attachment 8906652 [details]
Bug 1397731 - Clear Preferences search query after category switchover

Polish issue for pref search, let's uplift for beta 12.
Attachment #8906652 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified that this issue is fixed using Firefox 56 beta 12 and latest Nightly 57.0a1 across platforms (macOS 10.12.6, Windows 10 64bit and Ubuntu 16.04 32bit).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.