Closed
Bug 1397754
Opened 7 years ago
Closed 7 years ago
Application Menu > Avatar icon is out of alignment from other icons
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: abenson, Assigned: mikedeboer)
References
Details
(Keywords: regression, Whiteboard: [reserve-photon-structure])
Attachments
(2 files)
No description provided.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual] [triage]
Updated•7 years ago
|
Blocks: 1374815
Flags: needinfo?(gijskruitbosch+bugs) → qe-verify+
Keywords: regression
Priority: -- → P3
QA Contact: gwimberly
Whiteboard: [photon-visual] [triage] → [reserve-photon-structure]
Updated•7 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 1•7 years ago
|
||
I think I've got a fix for the thing you missed here.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Updated•7 years ago
|
Iteration: --- → 57.3 - Sep 19
Priority: P3 → P1
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8906019 [details] Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. https://reviewboard.mozilla.org/r/177778/#review182990 This fixes the labels on osx, but not the sync avatar icon mentioned in comment 0. :-) ::: browser/themes/osx/customizableui/panelUI.css:19 (Diff revision 1) > > .subviewbutton { > padding-inline-start: 18px; > } > > +photonpanelmultiview .toolbaritem-combined-buttons > label { I just got rid of a bunch of the photonpanelmultiview-specific descendant selectors. Is there a sensible way to avoid reintroducing them? ("Nope" is a valid answer, I'm just checking.)
Attachment #8906019 -
Flags: review?(gijskruitbosch+bugs)
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8906019 [details] Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. https://reviewboard.mozilla.org/r/177778/#review183304 ::: browser/themes/shared/customizableui/panelUI.inc.css:832 (Diff revision 2) > #appMenu-fxa-container:not([fxastatus="signedin"]) > #appMenu-fxa-status > #appMenu-fxa-avatar { > display: none; > } > > #appMenu-fxa-container[fxastatus="signedin"] > #appMenu-fxa-status > #appMenu-fxa-label { > /* 12px space before the avatar, then 16px for the avatar */ Can you also update this comment?
Attachment #8906019 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8906019 [details] Bug 1397754 - Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. https://reviewboard.mozilla.org/r/177778/#review182990 > I just got rid of a bunch of the photonpanelmultiview-specific descendant selectors. Is there a sensible way to avoid reintroducing them? ("Nope" is a valid answer, I'm just checking.) Nope :( I do think that we'll be able to get rid of, say, all the photonpanelmultiview-specific selectors soon.
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c33c05b5d47d Ensure that the FxA menu item in its signed in state and combined button widgets compensate for the correct inline start padding in subviews. r=Gijs
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c33c05b5d47d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 10•7 years ago
|
||
I have successfully reproduced this bug with Nightly 57.0a1 (2017-09-07) on windows 10 (32-bit) this bug is verified fix with latest nightly 57.0a1 (2017-09-12) (32-bit) Build ID: 20170912013600 Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170906]
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Comment 11•7 years ago
|
||
Weird. I never had such issue, but all of the sudden have and it started with today's nightly. See: https://s26.postimg.org/wv4ei9c9l/bug.png Avatar icon is out of position. Should I file the same bug again ?
Comment 12•7 years ago
|
||
(In reply to Eddward from comment #11) > Weird. I never had such issue, but all of the sudden have and it started > with today's nightly. > See: https://s26.postimg.org/wv4ei9c9l/bug.png > Avatar icon is out of position. > Should I file the same bug again ? Yes. This bug was filed against OS X. Your screenshot is from Windows. Looks like the shared/ bit in this patch wasn't quite right. :-\ Please file a new bug and needinfo me and/or mikedeboer.
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•