Closed Bug 1397803 Opened 8 years ago Closed 8 years ago

underline/overline are drawn in the wrong order in selected text

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1399310
Tracking Status
firefox57 --- affected

People

(Reporter: Gankra, Unassigned)

Details

Attachments

(2 files)

In nsTextFrame::PaintTextWithSelection, we draw text+shadows, followed by all decorations. This is incorrect; correct drawing order is: selection, shadow, underline, overline, text, strike-through. As a result, if you select some text, underlines and overlines will "jump" on top if it.
Attached image unselected.png
Attached image selected.png
I think this is a Layout: Web Painting bug, if not sorry & feel free to kick back to gfx.
Component: Graphics: Text → Layout: Web Painting
Ah, it appears I misread the code! It turns out that this is a side-effect of drawing the decorations multiple times (also incorrect). The last time we draw the decoration, the text is already drawn, so it gets drawn over.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: