stylo: we're not memory-reporting some ComputedValues for text

RESOLVED FIXED in Firefox 57

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks: 2 bugs)

53 Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

See bug 1397380 comment 8 item 3.

We have text ComputedValues that we're not reporting.

Maybe we should be reporting the stuff living in mNextInheritingAnonBoxStyle and mNextLazyPseudoStyle in ServoStyleContext; right now it looks like it could be non-reported if it's not reachable from any frames.
Created attachment 8905611 [details] [diff] [review]
Make sure to memory-report the ServoStyleContexts for anon boxes and lazy pseudos that we cache on the parent ServoStyleContext

This eliminates the unreported text style contexts on the HTML spec for me
Attachment #8905611 - Flags: review?(n.nethercote)
Comment on attachment 8905611 [details] [diff] [review]
Make sure to memory-report the ServoStyleContexts for anon boxes and lazy pseudos that we cache on the parent ServoStyleContext

Review of attachment 8905611 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. Did you verify with DMD?
Attachment #8905611 - Flags: review?(n.nethercote) → review+
Yes, I did.  That's what the "This eliminates ..." comment was about.
Priority: -- → P3

Comment 4

a year ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0fdf712c724
Make sure to memory-report the ServoStyleContexts for anon boxes and lazy pseudos that we cache on the parent ServoStyleContext.  r=njn
https://hg.mozilla.org/mozilla-central/rev/f0fdf712c724
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.