Closed
Bug 1397813
Opened 7 years ago
Closed 7 years ago
stylo: we're not memory-reporting some ComputedValues for text
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See bug 1397380 comment 8 item 3. We have text ComputedValues that we're not reporting. Maybe we should be reporting the stuff living in mNextInheritingAnonBoxStyle and mNextLazyPseudoStyle in ServoStyleContext; right now it looks like it could be non-reported if it's not reachable from any frames.
Assignee | ||
Comment 1•7 years ago
|
||
This eliminates the unreported text style contexts on the HTML spec for me
Attachment #8905611 -
Flags: review?(n.nethercote)
Comment 2•7 years ago
|
||
Comment on attachment 8905611 [details] [diff] [review] Make sure to memory-report the ServoStyleContexts for anon boxes and lazy pseudos that we cache on the parent ServoStyleContext Review of attachment 8905611 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable. Did you verify with DMD?
Attachment #8905611 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Yes, I did. That's what the "This eliminates ..." comment was about.
Updated•7 years ago
|
Priority: -- → P3
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0fdf712c724 Make sure to memory-report the ServoStyleContexts for anon boxes and lazy pseudos that we cache on the parent ServoStyleContext. r=njn
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f0fdf712c724
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•