Closed Bug 1397818 Opened 3 years ago Closed 3 years ago
"Clear private data on exit" should work
59 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1266594 +++ Basically a repeat performance of bug 1343995 caused by bug 1363001 (and I unfortunately overlooked it during review). Our telemetry is also showing a suspicious drop in the time taken for FX_SANITIZE_TOTAL, because we're mostly no longer waiting for sanitising to finish before declaring success.
Ah I see the problem, sorry not to see this issue, prior to landing bug 1363001. Is it possible that, this may be causing the AWSY regression? [bug 1395078]
I don't think so - AWSY just starts up the browser, loads a page, waits, closes the page again, waits and measures the memory usage at various points during that process both before and after doing a garbage collection. None of that has anything to do with the Sanitizer code.
Comment on attachment 8905598 [details] Bug 1397818 - Make sure to always return Promises from the Sanitizer. https://reviewboard.mozilla.org/r/177396/#review183484 Looks fine to me; as far as I can tell all implementations of "clear" return/yield promises.
Attachment #8905598 - Flags: review?(gkruglov) → review+
Yes, the original clearItem logic, which now resides in _clear, already did that, but nobody - me included - payed enough attention when this was moved in bug bug 1363001 and the new clearItem parameter validation logic was added.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f51248231d0e Make sure to always return Promises from the Sanitizer. r=Grisha
I had to back this out for eslint failures like https://treeherder.mozilla.org/logviewer.html#?job_id=130177001&repo=autoland https://hg.mozilla.org/integration/autoland/rev/db9a3beb8384
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ee906ef08263 Make sure to always return Promises from the Sanitizer. r=Grisha
You need to log in before you can comment on or make changes to this bug.