1397833 - Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Invalid key exchange group.) in nsNSSCallbacks.cpp:859

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Alex Gaynor [:Alex_Gaynor]]

(Wasn't sure if this belonged in nss, PSM, or something else)

Reproducible for me 100%, STR:

- Build nightly from hg (3c96d611ebd6)
- ./mach run
- Browse to badssl.com/dashboard/

Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Invalid key exchange group.), at /Users/agaynor/projects/mozilla-central/security/manager/ssl/nsNSSCallbacks.cpp:859
#01: CanFalseStartCallback(PRFileDesc*, void*, int*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x435c3f6]
#02: ssl3_CheckFalseStart[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/libnss3.dylib +0x1eba5c]
#03: ssl3_AuthCertificateComplete[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/libnss3.dylib +0x1eb687]
#04: SSL_AuthCertificateComplete[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/libnss3.dylib +0x202a7b]
#05: nsNSSSocketInfo::SetCertVerificationResult(int, mozilla::psm::SSLErrorMessageType)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x437a614]
#06: mozilla::psm::(anonymous namespace)::SSLServerCertVerificationResult::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4347b1a]
#07: nsThread::ProcessNextEvent(bool, bool*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x137622]
#08: NS_ProcessNextEvent(nsIThread*, bool)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x13a0b0]
#09: mozilla::net::nsSocketTransportService::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x23ced4]
[Child 76845] WARNING: We've already scheduled a task for background list flush.: file /Users/agaynor/projects/mozilla-central/parser/html/nsHtml5TreeOpExecutor.cpp, line 283
#10: non-virtual thunk to mozilla::net::nsSocketTransportService::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x23dc9d]
#11: nsThread::ProcessNextEvent(bool, bool*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x137622]
#12: NS_ProcessNextEvent(nsIThread*, bool)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x13a0b0]
#13: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6d1642]
#14: MessageLoop::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x683743]
#15: nsThread::ThreadFunc(void*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x134a36]
#16: _pt_root[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.app/Contents/MacOS/libnss3.dylib +0x14a8ca]
#17: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x393b]
#18: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x3887]

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Narrowed it down to dh1024.badssl.com which specifically causes the crash.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Franziskus, can you have a look?

Comment 3

[Franziskus Kiefer [:franziskus]]

Attachment: Bug 1397833 - don't assert on custom groups,

Review commit: https://reviewboard.mozilla.org/r/177666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177666/

Comment 4

[Franziskus Kiefer [:franziskus]]

Hm, I can't reproduce this but I can imagine where's it's coming from. I'll move this function into NSS soon to avoid any problems like this.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8905856 [details]
Bug 1397833 - don't assert on custom groups,

https://reviewboard.mozilla.org/r/177666/#review182830

lgtm with minor nits

::: commit-message-af5f4:1
(Diff revision 1)
> +Bug 1397833 - don't assert on custom groups, r?keeler

nit: maybe a bit more detail that this is specific to tls key exchange groups

::: devtools/client/locales/en-US/netmonitor.properties:775
(Diff revision 1)
>  # LOCALIZATION NOTE (netmonitor.security.keaGroup.none): This is the label
>  # displayed in the security tab describing the case when no group was used.
>  netmonitor.security.keaGroup.none=none
>  
> +# LOCALIZATION NOTE (netmonitor.security.keaGroup.custom): This is the label
> +# displayed in the security tab describing the case when no group was used.

s/no groups/a custom group/

Comment 6

[Bob Clary [:bc] (inactive)]

This reproduced in bughunter and locally on Fedora 26 with:
https://football24.ua/vidbir_yevro_2019_u_21_andorra__ukrayina__06__video_goliv_i_oglyad_matchu_n404369/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f13d106fc678
don't assert on custom TLS key-exchange groups, r=keeler

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f13d106fc678