1397839 - change docker-image task labels from build-docker-image-<imageName> to build-docker-image:<imageName>

Status: RESOLVED INACTIVE

(Firefox Build System :: Task Configuration, task)

Description

[Jonas Finnemann Jensen (:jonasfj)]

This is really simple:
  build-docker-image-<imageName>   ->   build-docker-image:<imageName>

Or maybe something better, but using a colon instead of a dash would help a lot in some of these cases. (yes, I know this is simple)

Thoughts? Any technical reason not to? any non-technical reasons not to? :)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

All of the labels are dash-separated so far.  I'm not sure this wouldn't run afoul of something that's handling labels.  Why does the colon help?

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

I as looking at labels in |mach try fuzzy --full| and it's really hard when things are called:
  build-qemu-image-docker-image-builder


a separator would make these labels more readable :) but I want to keep things consistent..


Anyways, this is just a nit suggestion..

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I'm of two minds.  Mind 1: let's wait until stuff calms down around in-tree configuration, rather than potentially introducing breakage to an already turbulent area.  Mind 2: let's get some `:` characters in labels now to flush out any issues with colons.

I'm leaning toward Mind 2, really.

Note that changing labels has the potential to break things, too.  Labels for "the same task" are expected to be stable over the long term, to support analysis and things like SETA.  I don't think much depends on that right now, and certainly not for the image tasks, but it does mean that wholesale label rewriting may introduce some temporary breakage.

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

> Note that changing labels has the potential to break things, too.  Labels for "the same task" are expected to be stable over the long term, to support analysis and things like SETA.

Interesting note, thanks.


Maybe we wait a week or two, there is really no rush to do this.

Comment 30

[Julien Cristau [:jcristau]]

Restricting comments on this bug since it's become a spam trap.