Fix 1Password Integration

VERIFIED FIXED

Status

()

Firefox for iOS
General
P2
normal
VERIFIED FIXED
6 months ago
4 months ago

People

(Reporter: st3fan, Assigned: farhan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0, fxios-v10.0 verified)

Details

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
garvan
: review+
Details | Review | Splinter Review
(Reporter)

Description

6 months ago
With bug 1394786 we simplified the sharing code, which unfortunately resulted in 1Password not working anymore. This bug is to bring 1Password support back.

Comment 1

5 months ago
1Password bug for this:
https://github.com/agilebits/onepassword-app-extension/issues/385
(Reporter)

Updated

5 months ago
tracking-fxios: 9.1 → 10.0
(Reporter)

Updated

5 months ago
tracking-fxios: 10.0 → 9.1

Comment 2

5 months ago
Not fixed yet on iOS 11.0.1.
tracking-fxios: 9.1 → 10.0

Comment 3

5 months ago
It isn't iOS that will fix it. It is Mozilla that needs to re-add support for 1Pass, they removed it after some other unrelated security issues. I can confirm in the latest FF build it is not fixed either :( Hopefully it is fixed soon as I cannot use FireFox without 1Pass support.

Comment 4

5 months ago
We are very aware and concerned about lack of 1PW, and are tracking this bug closely.

(In reply to Spaldo from comment #3)
> It isn't iOS that will fix it. 

I disagree, it is a fatal XPC lockup in iOS app runtime. Apple is aware, we are awaiting further news from them.
As filed here: 1Password outside of our app fails in the same way: https://github.com/agilebits/onepassword-app-extension/issues/385

> It is Mozilla that needs to re-add support
> for 1Pass, they removed it after some other unrelated security issues. 

I am the one who removed it, there was no security issue. The required UTI type to activate the 1Password extension is broken (triggers an XPC lockup).

Comment 5

5 months ago
My apologies garvan, I was obviously misinformed what the problem was... Hopefully Apple can help fix it soon then :)
tracking-fxios: 10.0 → 10.1
Priority: -- → P2

Comment 6

4 months ago
This mean we are still waiting on Apple?
(Assignee)

Comment 7

4 months ago
Created attachment 8923546 [details] [review]
Pull Request
Attachment #8923546 - Flags: review?(gkeeley)
(Assignee)

Updated

4 months ago
tracking-fxios: 10.1 → 10.0
(Assignee)

Updated

4 months ago
Assignee: nobody → fpatel

Updated

4 months ago
Attachment #8923546 - Flags: review?(gkeeley) → review+
(Assignee)

Comment 8

4 months ago
https://github.com/mozilla-mobile/firefox-ios/commit/73081c03882fed7ea1fa45d4e0a566687acd5616
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
(Reporter)

Comment 9

4 months ago
Uplifted to v10.x
Verifying as fix on 10.0 (7583).
Status: RESOLVED → VERIFIED
status-fxios-v10.0: --- → verified
You need to log in before you can comment on or make changes to this bug.