Closed Bug 1397894 Opened 7 years ago Closed 7 years ago

Custom tabs: fix loading pages

Categories

(GeckoView :: General, enhancement, P1)

51 Branch
All
Android
enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file)

In bug 1396065 we've extended GeckoView to support general URI load delegation but failed to update the onLoadUri callback for custom tabs to account for that.
Fire the generic view intent for external links and let Gecko handle the load otherwise.

We might want to extent the intent-based handling to links outside of the current domain.
Attachment #8905658 - Flags: review?(snorp)
s/extent/extend
Attachment #8905658 - Flags: review?(snorp) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83d8880fbf0e
[1.0] Fix GeckoView custom tabs URI loading. r=snorp
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/83d8880fbf0e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 57 → mozilla57
You need to log in before you can comment on or make changes to this bug.