Closed
Bug 1397902
Opened 7 years ago
Closed 7 years ago
Implement the copy change to the Stub Installer
Categories
(Firefox :: Installer, enhancement)
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: nyee, Assigned: molly)
References
Details
Attachments
(2 files)
Updating the stub installer copy to reflect the moz.org rebranding for 57. Copy can be found here: https://docs.google.com/document/d/1V6Lxg3l33CAMApR64IvHYxVmINB2N1-slYyq1u9kd9o/edit?ts=59af5a2b
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → mhowell
To be super clear, Change the headline above the green progress bar to Now installing . . . Then change the three rotating copy lines below the green progress bar to: The fastest, most responsive Firefox yet Faster page loading and tab switching Powerful private browsing The Firefox Installer copy in the app chrome is not changing, nor is the Built for people, not profit line in the lower RH corner.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8905673 [details] Bug 1397902 - Pre-land new stub installer header and blurb strings. https://reviewboard.mozilla.org/r/177464/#review182530
Attachment #8905673 -
Flags: review?(agashlin) → review+
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f82f69a3381a Pre-land new stub installer header and blurb strings. r=agashlin
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8905673 [details] Bug 1397902 - Pre-land new stub installer header and blurb strings. https://reviewboard.mozilla.org/r/177464/#review182626 I'm going to ask for a back-out from autoland. To avoid any possible confusion when looking at the code, can we go with better string IDs? E.g. NEW_STUB_INSTALLING_LABEL NEW_STUB_BLURB1 NEW_STUB_BLURB2 NEW_STUB_BLURB3 ::: browser/locales/en-US/installer/nsisstrings.properties:32 (Diff revision 1) > STUB_CLEANUP_PAVEOVER_BUTTON=&Update > STUB_CLEANUP_REINSTALL_BUTTON=Re-&install > STUB_CLEANUP_CHECKBOX_LABEL=&Restore default settings and remove old add-ons for optimal performance > > STUB_INSTALLING_LABEL=Now installing > +STUB_INSTALLING_LABEL2=Now installing . . . Do not use dots for an ellipsis, definitely not spaced dots. This should be STUB_INSTALLING_LABEL2=Now installing… ::: browser/locales/en-US/installer/nsisstrings.properties:36 (Diff revision 1) > STUB_INSTALLING_LABEL=Now installing > +STUB_INSTALLING_LABEL2=Now installing . . . > STUB_BLURB1=Fast, responsive online experiences > STUB_BLURB2=Compatibility with more of your favorite sites > STUB_BLURB3=Built-in privacy tools for safer browsing > +STUB_BLURBS2_1=The fastest, most responsive Firefox yet You don't hard code Firefox in strings, there's $BrandShortName for that (see other strings)
Attachment #8905673 -
Flags: review-
Comment 6•7 years ago
|
||
Sebastian, can you back this out from autoland?
Flags: needinfo?(aryx.bugmail)
Comment 7•7 years ago
|
||
Backed out as requested by flod: https://hg.mozilla.org/integration/autoland/rev/c54babd134d3400891d83920bc71eb45243a1566
Flags: needinfo?(aryx.bugmail) → needinfo?(mhowell)
Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/50857982881a Backed out changeset f82f69a3381a on request from flod for improvable strings and string ids. r=backout a=backout
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5) Thanks for the feedback. > To avoid any possible confusion when looking at the code, can we go with > better string IDs? E.g. > > NEW_STUB_INSTALLING_LABEL > NEW_STUB_BLURB1 > NEW_STUB_BLURB2 > NEW_STUB_BLURB3 There need to be new labels every time the strings are changed, right? Since these strings are tied into marketing/branding and the onboarding process, I doubt this is the last time they are ever going to be changed (this is already the second version in a few months), so we would end up with "NEW_NEW_NEW_NEW_STUB_BLURB1" before long, and I'm not okay with that. So I gave them numbers. If you have another suggestion, I'd be interested, but just having a prefix is not going to work out. > ::: browser/locales/en-US/installer/nsisstrings.properties:32 > (Diff revision 1) > > STUB_CLEANUP_PAVEOVER_BUTTON=&Update > > STUB_CLEANUP_REINSTALL_BUTTON=Re-&install > > STUB_CLEANUP_CHECKBOX_LABEL=&Restore default settings and remove old add-ons for optimal performance > > > > STUB_INSTALLING_LABEL=Now installing > > +STUB_INSTALLING_LABEL2=Now installing . . . > > Do not use dots for an ellipsis, definitely not spaced dots. > > This should be > STUB_INSTALLING_LABEL2=Now installing… Okay, I'll do that. The need for this is news to me though; I'm curious what the reason for that requirement is? > ::: browser/locales/en-US/installer/nsisstrings.properties:36 > (Diff revision 1) > > STUB_INSTALLING_LABEL=Now installing > > +STUB_INSTALLING_LABEL2=Now installing . . . > > STUB_BLURB1=Fast, responsive online experiences > > STUB_BLURB2=Compatibility with more of your favorite sites > > STUB_BLURB3=Built-in privacy tools for safer browsing > > +STUB_BLURBS2_1=The fastest, most responsive Firefox yet > > You don't hard code Firefox in strings, there's $BrandShortName for that > (see other strings) You're right, that was a silly mistake; I'll fix that.
Flags: needinfo?(mhowell) → needinfo?(francesco.lodolo)
Comment 10•7 years ago
|
||
(In reply to Matt Howell [:mhowell] from comment #9) > There need to be new labels every time the strings are changed, right? Since > these strings are tied into marketing/branding and the onboarding process, I > doubt this is the last time they are ever going to be changed (this is > already the second version in a few months), so we would end up with > "NEW_NEW_NEW_NEW_STUB_BLURB1" before long, and I'm not okay with that. So I > gave them numbers. If you have another suggestion, I'd be interested, but > just having a prefix is not going to work out. Yes, they need to change. The only really confusing part is STUB_BLURBS2_1, STUB_BLURBS2_2, STUB_BLURBS2_3. Maybe STUB2_BLURBS_1, etc. is a little less confusing (moving the 2 after STUB). > Okay, I'll do that. The need for this is news to me though; I'm curious what > the reason for that requirement is? Consistency is definitely one (all strings in Firefox use …), proper typography is another. http://practicaltypography.com/ellipses.html
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #10) > Yes, they need to change. The only really confusing part is STUB_BLURBS2_1, > STUB_BLURBS2_2, STUB_BLURBS2_3. Maybe STUB2_BLURBS_1, etc. is a little less > confusing (moving the 2 after STUB). Hmm. I don't know if that's less confusing; STUB doesn't describe the thing being incremented. What do you think about using words instead of numbers to indicate the sequence? Something like STUB_BLURB_FIRST_2, STUB_BLURB_SECOND_2, and STUB_BLURB_THIRD_2. I don't expect the number of blurb strings to change much, so this should be stable enough. It's still not 100% clear, but I think it's an improvement.
Flags: needinfo?(francesco.lodolo)
Comment 12•7 years ago
|
||
That works for me, also no need for the underscore if you prefer (STUB_BLURB_SECOND1)
Flags: needinfo?(francesco.lodolo)
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8905673 [details] Bug 1397902 - Pre-land new stub installer header and blurb strings. https://reviewboard.mozilla.org/r/177464/#review182860
Attachment #8905673 -
Flags: review?(francesco.lodolo) → review+
Comment 15•7 years ago
|
||
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10090de4624b Pre-land new stub installer header and blurb strings. r=agashlin,flod
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/10090de4624b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 17•7 years ago
|
||
Attachment #8907254 -
Flags: review?(francesco.lodolo)
Attachment #8907254 -
Flags: review?(agashlin)
Updated•7 years ago
|
Attachment #8907254 -
Flags: review?(agashlin) → review+
Updated•7 years ago
|
Attachment #8907254 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Comment 18•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9583ea83ff4ab3042bca04c485d936862f0370d4 Bug 1397902 - Switch on the new stub installer strings and remove the old ones. r=agashlin,flod
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9583ea83ff4a
Comment 20•7 years ago
|
||
Verified fixed on Windows 7 x64 and Windows 10 x86 using Fireofx 57 Beta 4/5: Header is "Now installing...", Sub 1 is "The fastest, most responsive Firefox yet", Sub 2 is "Faster page loading and tab switching" and Sub 3 is "Powerful private browsing".
Status: RESOLVED → VERIFIED
Comment 21•7 years ago
|
||
I forgot to mention that I've tested on en-us build and on the following localization builds: ach,af,an,ar,fr,as,ast,az,be,bn-bd,bn-IN,br,bs,ca,cak,cs,cy,da,en-GB,es-AR,es-ES,fa,he,hu,hy-AM,it,ka,lt,mr,pl,ru,sl,tr,zh-TW.
You need to log in
before you can comment on or make changes to this bug.
Description
•