Closed
Bug 1397934
Opened 8 years ago
Closed 8 years ago
[meta] Fix ios10 deprecation warnings
Categories
(Firefox for iOS :: Browser, enhancement, P3)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: farhan, Unassigned)
References
Details
(Whiteboard: [MobileCore])
Attachments
(3 files)
The following methods are deprecated.
UILocalNotifications
UIUserNotificationSettings
UIColor.init(colorLiteralRed:green:blue:alpha:)
UIApplication.shared.openURL
OSSpinLock
|
||
Comment 1•8 years ago
|
||
Converting to meta.
Summary: Fix ios10 deprecation warnings → [meta] Fix ios10 deprecation warnings
Whiteboard: [MobileCore]
|
|
Reporter | |
Updated•8 years ago
|
Priority: -- → P3
Attachment #8919237 -
Flags: review?(fpatel)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8919237 -
Flags: review?(fpatel) → review?(jhugman)
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8919237 [details] [review]
Pull request
Added some comments in the PR.
Attachment #8919237 -
Flags: review?(jhugman) → feedback+
Attachment #8919237 -
Flags: feedback+ → review?(jhugman)
|
|
||
Comment 5•8 years ago
|
||
Reminder that we need a follow-up to properly handle "Open in App" when web content attempts to deep-link into native apps.
|
|
||
Comment 6•8 years ago
|
||
The follow-up I'm referring to is in Bug 1396989.
|
|
||
Updated•8 years ago
|
Attachment #8919237 -
Flags: review?(jhugman) → review+
|
|
||
Comment 7•8 years ago
|
||
Unmodified version of original PR.
Flags: needinfo?(jhugman)
Attachment #8925534 -
Flags: review+
|
|
||
Comment 8•8 years ago
|
||
Merged into master.
Callie D: Thank you so much for your contribution.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
This line is wrong, should be an unlock, not a lock:
https://github.com/mozilla-mobile/firefox-ios/blob/a7bed48a3ce4b9332e44c740021d11ba6d13d331/Account/FirefoxAccount.swift#L397
Patch incoming
|
|
||
Comment 10•8 years ago
|
||
Follow up patch to fix an unlock becoming a lock.
Attachment #8926970 -
Flags: review?(jdarcangelo)
|
|
||
Updated•8 years ago
|
Attachment #8926970 -
Flags: review?(jdarcangelo) → review+
|
|
||
Comment 11•8 years ago
|
||
garvankeeley merged commit 049a351 into mozilla-mobile:master just now
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•