1397938 - Download protection whitelist and blacklist are not available for the Android platform

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[François Marier [:francois]]

Since the download protection lists are not available on Fennec, we should override these prefs in mobile/android/app/mobile.js:

urlclassifier.downloadAllowTable = ""
urlclassifier.downloadBlockTable = ""

It won't have any immediate effect since download protection is currently disabled on Fennec.

Comment 1

[Ethan Tseng [:ethan]]

Attachment: bug-1397938.patch

Thomas,
What would you suggest me to test the patch?
Should we write a test case for it?  Or just verify it manually?

Comment 2

[Thomas Nguyen (:tnguyen)]

Comment 0, you may not need to test the patch. In current Fennec, even if you manually try to enable download protection in android, you still may not see the tables appears in your database (both with and with out your patch).

Comment 3

[Ethan Tseng [:ethan]]

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #2)
> Comment 0, you may not need to test the patch. In current Fennec, even if
> you manually try to enable download protection in android, you still may not
> see the tables appears in your database (both with and with out your patch).

Sure. But I thought we should at least check the preference values manually, no?

Comment 4

[Thomas Nguyen (:tnguyen)]

Ah, yes, of course. Just go to about:config to see if the pref is changed. But no test case is needed

Comment 5

[Ethan Tseng [:ethan]]

Comment on attachment 8906883 [details] [diff] [review]
bug-1397938.patch

I verified the pref values manually on Fennec.

Comment 6

[François Marier [:francois]]

Comment on attachment 8906883 [details] [diff] [review]
bug-1397938.patch

Review of attachment 8906883 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/app/mobile.js
@@ +145,4 @@
>  pref("browser.sessionstore.privacy_level", 0); // saving data: 0 = all, 1 = unencrypted sites, 2 = never
>  pref("browser.sessionstore.debug_logging", false);
>  
> +/* Safe Browsing */

nit: no need for this comment

Comment 7

[Ethan Tseng [:ethan]]

(In reply to François Marier [:francois] from comment #6)
> > +/* Safe Browsing */ 
> nit: no need for this comment

Thanks, Francois!

Comment 8

[Ethan Tseng [:ethan]]

Attachment: bug-1397938.patch

Fixed the nit and refreshed the commit message "r=francois."

Comment 9

[Ethan Tseng [:ethan]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cd1bfba637ec708da495a705f601affe3031b98

Comment 10

[Ethan Tseng [:ethan]]

Try result looks good.
All the failures are known intermittent failures not relevant to this patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e62c82e6dac
Download protection whitelist and blacklist are not available for the Android platform. r=francois

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8e62c82e6dac