Closed
Bug 1397938
Opened 7 years ago
Closed 7 years ago
Download protection whitelist and blacklist are not available for the Android platform
Categories
(Toolkit :: Safe Browsing, enhancement, P3)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: francois, Assigned: ethan)
References
(Blocks 1 open bug)
Details
(Whiteboard: #sbv4-m10)
Attachments
(1 file, 1 obsolete file)
984 bytes,
patch
|
Details | Diff | Splinter Review |
Since the download protection lists are not available on Fennec, we should override these prefs in mobile/android/app/mobile.js: urlclassifier.downloadAllowTable = "" urlclassifier.downloadBlockTable = "" It won't have any immediate effect since download protection is currently disabled on Fennec.
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ettseng
Assignee | ||
Comment 1•7 years ago
|
||
Thomas, What would you suggest me to test the patch? Should we write a test case for it? Or just verify it manually?
Flags: needinfo?(tnguyen)
Comment 2•7 years ago
|
||
Comment 0, you may not need to test the patch. In current Fennec, even if you manually try to enable download protection in android, you still may not see the tables appears in your database (both with and with out your patch).
Flags: needinfo?(tnguyen)
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #2) > Comment 0, you may not need to test the patch. In current Fennec, even if > you manually try to enable download protection in android, you still may not > see the tables appears in your database (both with and with out your patch). Sure. But I thought we should at least check the preference values manually, no?
Comment 4•7 years ago
|
||
Ah, yes, of course. Just go to about:config to see if the pref is changed. But no test case is needed
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8906883 [details] [diff] [review] bug-1397938.patch I verified the pref values manually on Fennec.
Attachment #8906883 -
Flags: review?(francois)
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8906883 [details] [diff] [review] bug-1397938.patch Review of attachment 8906883 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/app/mobile.js @@ +145,4 @@ > pref("browser.sessionstore.privacy_level", 0); // saving data: 0 = all, 1 = unencrypted sites, 2 = never > pref("browser.sessionstore.debug_logging", false); > > +/* Safe Browsing */ nit: no need for this comment
Attachment #8906883 -
Flags: review?(francois) → review+
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to François Marier [:francois] from comment #6) > > +/* Safe Browsing */ > nit: no need for this comment Thanks, Francois!
Assignee | ||
Comment 8•7 years ago
|
||
Fixed the nit and refreshed the commit message "r=francois."
Attachment #8906883 -
Attachment is obsolete: true
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cd1bfba637ec708da495a705f601affe3031b98
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•7 years ago
|
||
Try result looks good. All the failures are known intermittent failures not relevant to this patch.
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e62c82e6dac Download protection whitelist and blacklist are not available for the Android platform. r=francois
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e62c82e6dac
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•