Closed Bug 1397979 Opened 4 years ago Closed 4 years ago

Various WebVR web-platform-tests are going to permafail when Gecko 57 merges to Beta on 2017-09-14

Categories

(Core :: WebVR, defect)

57 Branch
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 + verified

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing tests on the next merge day.

Looks like these were just added by bug 1397215. Presumably we just need to make sure the pref is flipped on when they run.

https://treeherder.mozilla.org/logviewer.html#?job_id=129385823&repo=try

TEST-UNEXPECTED-PASS | /webvr/webvr-disabled-by-feature-policy.https.sub.html | Feature-Policy header vr "none" disallows same-origin iframes. - expected FAIL
TEST-UNEXPECTED-PASS | /webvr/webvr-disabled-by-feature-policy.https.sub.html | Feature-Policy header vr "none" disallows cross-origin iframes. - expected FAIL
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows the top-level document. - navigator.getVRDisplays is not a function
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows same-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows cross-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" allows the top-level document. - navigator.getVRDisplays is not a function
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" allows same-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-PASS | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" disallows cross-origin iframes. - expected FAIL
Flags: needinfo?(james)
This is Linux/OSX only since WebVR is already enabled on Windows for Beta/Release.
Please add prefs: [dom.vr.enabled:true] as testing/web-platform/meta/webvr/idlharness.html.ini at new *.ini
Try says this works.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8905761 - Flags: review?(james)
Comment on attachment 8905761 [details] [diff] [review]
flip the dom.vr.enabled pref at the directory level

Takk
Flags: needinfo?(james)
Attachment #8905761 - Flags: review?(james) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/80604d1eb775
Flip the dom.vr.enabled pref when running the WebVR web-platform-tests. r=jgraham
https://hg.mozilla.org/mozilla-central/rev/80604d1eb775
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.