Various WebVR web-platform-tests are going to permafail when Gecko 57 merges to Beta on 2017-09-14

VERIFIED FIXED in Firefox 57

Status

()

--
critical
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

57 Branch
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57+ verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
[Tracking Requested - why for this release]: Permafailing tests on the next merge day.

Looks like these were just added by bug 1397215. Presumably we just need to make sure the pref is flipped on when they run.

https://treeherder.mozilla.org/logviewer.html#?job_id=129385823&repo=try

TEST-UNEXPECTED-PASS | /webvr/webvr-disabled-by-feature-policy.https.sub.html | Feature-Policy header vr "none" disallows same-origin iframes. - expected FAIL
TEST-UNEXPECTED-PASS | /webvr/webvr-disabled-by-feature-policy.https.sub.html | Feature-Policy header vr "none" disallows cross-origin iframes. - expected FAIL
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows the top-level document. - navigator.getVRDisplays is not a function
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows same-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-by-feature-policy.https.sub.html | Feature-Policy header vr * allows cross-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" allows the top-level document. - navigator.getVRDisplays is not a function
TEST-UNEXPECTED-FAIL | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" allows same-origin iframes. - assert_true: navigator.getVRDisplays() expected true got false
TEST-UNEXPECTED-PASS | /webvr/webvr-enabled-on-self-origin-by-feature-policy.https.sub.html | Feature-Policy header vr "self" disallows cross-origin iframes. - expected FAIL
Flags: needinfo?(james)
(Assignee)

Comment 1

a year ago
This is Linux/OSX only since WebVR is already enabled on Windows for Beta/Release.
Please add prefs: [dom.vr.enabled:true] as testing/web-platform/meta/webvr/idlharness.html.ini at new *.ini
(Assignee)

Comment 3

a year ago
Created attachment 8905761 [details] [diff] [review]
flip the dom.vr.enabled pref at the directory level

Try says this works.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8905761 - Flags: review?(james)
Comment on attachment 8905761 [details] [diff] [review]
flip the dom.vr.enabled pref at the directory level

Takk
Flags: needinfo?(james)
Attachment #8905761 - Flags: review?(james) → review+

Comment 5

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/80604d1eb775
Flip the dom.vr.enabled pref when running the WebVR web-platform-tests. r=jgraham

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/80604d1eb775
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Updated

a year ago
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
tracking-firefox57: ? → +
You need to log in before you can comment on or make changes to this bug.