Closed
Bug 1397980
Opened 7 years ago
Closed 7 years ago
test_worker_interfaces.html is going to permafail when Gecko 57 merges to Beta on 2017-09-14
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla57
People
(Reporter: RyanVM, Assigned: hiro)
References
Details
Attachments
(1 file)
[Tracking Requested - why for this release]: Permafailing tests on the next merge day. Looks like test_interfaces.js got updated but test_worker_interfaces.js didn't. https://hg.mozilla.org/mozilla-central/file/default/dom/workers/test/test_worker_interfaces.js#l183 https://treeherder.mozilla.org/logviewer.html#?job_id=129387103&repo=try TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface PerformanceObserver to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface PerformanceObserverEntryList to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | false: If this is failing: DANGER, are you sure you want to expose the new interface PerformanceObserver to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | false: If this is failing: DANGER, are you sure you want to expose the new interface PerformanceObserverEntryList to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
Flags: needinfo?(hikezoe)
Assignee | ||
Comment 1•7 years ago
|
||
Oops, I did miss the test case in bug 1386021. We should drop 'nightly' there.
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe)
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a34c3b82c675dffb6490396d51e7733443dd6a73
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8905750 [details] Bug 1397980 - Drop nightly only flag for PerformanceObserver and PerformanceObserverEntryList. Bah, I missed that dom/workers/test/serviceworkers/test_serviceworker_interfaces.html is hitting the same ones. Need to update test_serviceworker_interfaces.js as well.
Flags: needinfo?(hikezoe)
Attachment #8905750 -
Flags: feedback-
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8905750 [details] Bug 1397980 - Drop nightly only flag for PerformanceObserver and PerformanceObserverEntryList. https://reviewboard.mozilla.org/r/177556/#review182644
Attachment #8905750 -
Flags: review?(amarchesini) → review+
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5baccd396fc4 Drop nightly only flag for PerformanceObserver and PerformanceObserverEntryList. r=baku
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5baccd396fc4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•