Closed Bug 1397982 Opened 4 years ago Closed 4 years ago

test_interfaces.html and test_worker_interfaces.html are going to permafail when Gecko 57 merges to Beta on 2017-09-14

Categories

(Core :: DOM: Core & HTML, defect)

57 Branch
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 + verified

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file, 1 obsolete file)

[Tracking Requested - why for this release]: Permafailing tests on the next merge day.

Looks like test_interfaces.js and test_worker_interfaces.js need some updates.

https://treeherder.mozilla.org/logviewer.html#?job_id=129387119&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=129387103&repo=try

TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface AbortSignal to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface AbortController to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface AbortSignal to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces_secureContext.html | If this is failing: DANGER, are you sure you want to expose the new interface AbortController to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface AbortController to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface AbortSignal to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | false: If this is failing: DANGER, are you sure you want to expose the new interface AbortController to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | false: If this is failing: DANGER, are you sure you want to expose the new interface AbortSignal to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
Flags: needinfo?(amarchesini)
Attached patch update the test expectations (obsolete) — Splinter Review
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8905743 - Flags: review?(amarchesini)
Forgot to update test_serviceworker_interfaces.js in the last patch.
Attachment #8905743 - Attachment is obsolete: true
Attachment #8905743 - Flags: review?(amarchesini)
Attachment #8905760 - Flags: review?(amarchesini)
Attachment #8905760 - Flags: review?(amarchesini) → review+
Flags: needinfo?(amarchesini)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a02bd6e1c55e
Update the expectations for test_interfaces.js and test_worker_interfaces.js now that Abort API is being shipped by default. r=baku
https://hg.mozilla.org/mozilla-central/rev/a02bd6e1c55e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Status: RESOLVED → VERIFIED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.